Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update types of Animated FlatList and SectionList (#51602)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/51602

Changelog: [GENERAL][FIXED] - Fixed the generated type definitions for `Animated.FlatList` and `Animated.SectionList` to correctly infer item types.

Current definitions for animated list components cast away their generic definitions, preventing the types to be inferred from usage. This diff addresses that.

Reviewed By: huntie

Differential Revision: D75407762

fbshipit-source-id: c86f20298ded707971c05a78d025a63e82fe2a64
This commit is contained in:
Jakub Piasecki
2025-06-02 14:15:53 +00:00
committed by React Native Bot
parent 5cc63aa9ea
commit 302f3a4e5a
4 changed files with 30 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/Animated/AnimatedExports.js
Vendored
+2 -2
View File
@@ -25,7 +25,7 @@ const Animated: typeof AnimatedImplementation = Platform.isDisableAnimations
: AnimatedImplementation;
export default {
get FlatList(): AnimatedFlatList {
get FlatList(): AnimatedFlatList<any> {
return require('./components/AnimatedFlatList').default;
},
get Image(): AnimatedImage {
@@ -34,7 +34,7 @@ export default {
get ScrollView(): AnimatedScrollView {
return require('./components/AnimatedScrollView').default;
},
get SectionList(): AnimatedSectionList {
get SectionList(): AnimatedSectionList<any, any> {
return require('./components/AnimatedSectionList').default;
},
get Text(): AnimatedText {
packages/react-native/Libraries/Animated/components/AnimatedFlatList.js
Vendored
+7 -6
View File
@@ -8,13 +8,14 @@
* @format
*/
import type {AnimatedComponentType} from '../createAnimatedComponent';
import type {AnimatedProps} from '../createAnimatedComponent';
import FlatList from '../../Lists/FlatList';
import FlatList, {type FlatListProps} from '../../Lists/FlatList';
import createAnimatedComponent from '../createAnimatedComponent';
import * as React from 'react';
export default (createAnimatedComponent(FlatList): AnimatedComponentType<
React.ElementConfig<typeof FlatList>,
FlatList<mixed>,
>);
// $FlowExpectedError[unclear-type]
export default (createAnimatedComponent(FlatList): component<ItemT = any>(
ref?: React.RefSetter<FlatList<ItemT>>,
...props: AnimatedProps<FlatListProps<ItemT>>
));
packages/react-native/Libraries/Animated/components/AnimatedSectionList.js
Vendored
+11 -7
View File
@@ -8,15 +8,19 @@
* @format
*/
import type {SectionBase} from '../../Lists/SectionList';
import type {AnimatedComponentType} from '../createAnimatedComponent';
import type {AnimatedProps} from '../createAnimatedComponent';
import SectionList from '../../Lists/SectionList';
import SectionList, {type SectionListProps} from '../../Lists/SectionList';
import createAnimatedComponent from '../createAnimatedComponent';
import * as React from 'react';
export default (createAnimatedComponent(SectionList): AnimatedComponentType<
React.ElementConfig<typeof SectionList>,
// $FlowFixMe
export default (createAnimatedComponent(SectionList): component<
// $FlowExpectedError[unclear-type]
SectionList<any, SectionBase<any>>,
>);
ItemT = any,
// $FlowExpectedError[unclear-type]
SectionT = any,
>(
ref?: React.RefSetter<SectionList<ItemT, SectionT>>,
...props: AnimatedProps<SectionListProps<ItemT, SectionT>>
));
packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap
+10 -10
View File
@@ -156,10 +156,10 @@ declare export class AnimatedEvent {
exports[`public API should not change unintentionally Libraries/Animated/AnimatedExports.js 1`] = `
"declare const Animated: typeof AnimatedImplementation;
declare export default {
get FlatList(): AnimatedFlatList,
get FlatList(): AnimatedFlatList<any>,
get Image(): AnimatedImage,
get ScrollView(): AnimatedScrollView,
get SectionList(): AnimatedSectionList,
get SectionList(): AnimatedSectionList<any, any>,
get Text(): AnimatedText,
get View(): AnimatedView,
...typeof Animated,
@@ -614,10 +614,10 @@ exports[`public API should not change unintentionally Libraries/Animated/bezier.
`;
exports[`public API should not change unintentionally Libraries/Animated/components/AnimatedFlatList.js 1`] = `
"declare export default AnimatedComponentType<
React.ElementConfig<typeof FlatList>,
FlatList<mixed>,
>;
"declare export default component<ItemT = any>(
ref?: React.RefSetter<FlatList<ItemT>>,
...props: AnimatedProps<FlatListProps<ItemT>>
);
"
`;
@@ -641,10 +641,10 @@ declare export default typeof AnimatedScrollView;
`;
exports[`public API should not change unintentionally Libraries/Animated/components/AnimatedSectionList.js 1`] = `
"declare export default AnimatedComponentType<
React.ElementConfig<typeof SectionList>,
SectionList<any, SectionBase<any>>,
>;
"declare export default component<ItemT = any, SectionT = any>(
ref?: React.RefSetter<SectionList<ItemT, SectionT>>,
...props: AnimatedProps<SectionListProps<ItemT, SectionT>>
);
"
`;