Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Android: Ensure RN_FABRIC_ENABLED is defined when building with Fabric (#29939)

Browse Source 
Summary:
This pull request tweaks the build script for `jsiruntime` to ensure that `RN_FABRIC_ENABLED` is defined when building for Android with Fabric enabled, and using the JavascriptCore JS engine. Without it, the `createWeakObject` and `lockWeakObject` methods in `JSCRuntime.cpp` will throw an exception.

## Changelog

[Internal] [Changed] - Android: Ensure RN_FABRIC_ENABLED is defined when building with Fabric

Pull Request resolved: https://github.com/facebook/react-native/pull/29939

Test Plan: RNTester with JSC now builds and runs on Android with Fabric enabled.

Reviewed By: hramos

Differential Revision: D23671070

Pulled By: fkgozali

fbshipit-source-id: 27e69364a9f709615543be7c20b72b5536443cd8
This commit is contained in:
empyrical
2020-09-14 10:08:51 -07:00
committed by Facebook GitHub Bot
parent 6524e611d3
commit 300df59c77
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/jsi/Android.mk
+4
View File
@@ -32,4 +32,8 @@ LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)
LOCAL_CFLAGS := -fexceptions -frtti -O3
LOCAL_SHARED_LIBRARIES := libfolly_json libjsc glog
ifeq ($(BUILD_FABRIC),true)
LOCAL_CFLAGS += -DRN_FABRIC_ENABLED
endif
include $(BUILD_STATIC_LIBRARY)