Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't log for unavailable modules during reload

Browse Source 
Summary:
Removes logging for known invalid states.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D18966536

fbshipit-source-id: 483dce1d2bf0c6c92458f618789cf98dcf92ee97
This commit is contained in:
Rick Hanlon
2020-01-29 04:33:04 -08:00
committed by Facebook Github Bot
parent 947a5593ec
commit 2f9d94418d
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/CxxBridge/RCTCxxBridge.mm
+7 -4
View File
@@ -485,19 +485,22 @@ struct RCTInstanceCallback : public InstanceCallback {
return moduleData.instance;
}
static NSSet<NSString *> *ignoredModuleLoadFailures = [NSSet setWithArray: @[@"UIManager"]];
// Module may not be loaded yet, so attempt to force load it here.
const BOOL result = [self.delegate respondsToSelector:@selector(bridge:didNotFindModule:)] &&
[self.delegate bridge:self didNotFindModule:moduleName];
if (result) {
// Try again.
moduleData = _moduleDataByName[moduleName];
} else if ([ignoredModuleLoadFailures containsObject: moduleName]) {
RCTLogWarn(@"Unable to find module for %@", moduleName);
#if RCT_DEV
// If the `_moduleDataByName` is nil, it must have been cleared by the reload.
} else if (_moduleDataByName != nil) {
RCTLogError(@"Unable to find module for %@", moduleName);
}
#else
} else {
RCTLogError(@"Unable to find module for %@", moduleName);
}
#endif
return moduleData.instance;
}