Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve definitions in METAXXHashUtils (#49027)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/49027

Make constants more specific to `METAHash` (avoid potential conflicts) and unify the APIs with a shared attribute definition (will be used to mark these APIs as unavailable from Swift).

## Changelog:

[iOS] [Changed] - Change prime constants to have prefix in order to avoid any potential conflicts

Reviewed By: adamjernst

Differential Revision: D68790450

fbshipit-source-id: 69c8b73063cf57d6a4ec25f6cd52a906c77694f0
This commit is contained in:
Nolan O'Brien
2025-01-28 16:35:40 -08:00
committed by Facebook GitHub Bot
parent d797b7aa4d
commit 2ed0ba0722
1 changed files with 47 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/React/I18n/FBXXHashUtils.h
+47 -29
View File
@@ -29,39 +29,49 @@
NS_ASSUME_NONNULL_BEGIN
/// magic constants :-)
static const uint64_t PRIME1 = 11400714785074694791ULL;
static const uint64_t PRIME2 = 14029467366897019727ULL;
static const uint64_t PRIME3 = 1609587929392839161ULL;
static const uint64_t PRIME4 = 9650029242287828579ULL;
static const uint64_t PRIME5 = 2870177450012600261ULL;
static const uint64_t METAXXHASHUTILS_PRIME_1 = 11400714785074694791ULL;
static const uint64_t METAXXHASHUTILS_PRIME_2 = 14029467366897019727ULL;
static const uint64_t METAXXHASHUTILS_PRIME_3 = 1609587929392839161ULL;
static const uint64_t METAXXHASHUTILS_PRIME_4 = 9650029242287828579ULL;
static const uint64_t METAXXHASHUTILS_PRIME_5 = 2870177450012600261ULL;
NS_INLINE uint64_t rotl(uint64_t x, int r)
#define METAXXHASHUTILS_INLINE_ATTRS \
NS_SWIFT_UNAVAILABLE("You'll need to bridge to C/ObjC to use this API.") \
NS_INLINE
METAXXHASHUTILS_INLINE_ATTRS
uint64_t rotl(uint64_t x, int r)
{
return ((x << r) | (x >> (64 - r)));
}
NS_INLINE uint64_t mix1(const uint64_t h, const uint64_t prime, int rshift)
METAXXHASHUTILS_INLINE_ATTRS
uint64_t mix1(const uint64_t h, const uint64_t prime, int rshift)
{
return (h ^ (h >> rshift)) * prime;
}
NS_INLINE uint64_t mix2(const uint64_t p, const uint64_t v)
METAXXHASHUTILS_INLINE_ATTRS
uint64_t mix2(const uint64_t p, const uint64_t v)
{
return rotl(v + p * PRIME2, 31) * PRIME1;
return rotl(v + p * METAXXHASHUTILS_PRIME_2, 31) * METAXXHASHUTILS_PRIME_1;
}
NS_INLINE uint64_t mix3(const uint64_t h, const uint64_t v)
METAXXHASHUTILS_INLINE_ATTRS
uint64_t mix3(const uint64_t h, const uint64_t v)
{
return (h ^ mix2(v, 0)) * PRIME1 + PRIME4;
return (h ^ mix2(v, 0)) * METAXXHASHUTILS_PRIME_1 + METAXXHASHUTILS_PRIME_4;
}
NS_INLINE uint32_t endian32(const char *v)
METAXXHASHUTILS_INLINE_ATTRS
uint32_t endian32(const char *v)
{
return (uint32_t)((uint8_t)(v[0])) | ((uint32_t)((uint8_t)(v[1])) << 8)
| ((uint32_t)((uint8_t)(v[2])) << 16) | ((uint32_t)((uint8_t)(v[3])) << 24);
}
NS_INLINE uint64_t endian64(const char *v)
METAXXHASHUTILS_INLINE_ATTRS
uint64_t endian64(const char *v)
{
return (uint64_t)((uint8_t)(v[0])) | ((uint64_t)((uint8_t)(v[1])) << 8)
| ((uint64_t)((uint8_t)(v[2])) << 16) | ((uint64_t)((uint8_t)(v[3])) << 24)
@@ -69,50 +79,58 @@ NS_INLINE uint64_t endian64(const char *v)
| ((uint64_t)((uint8_t)(v[6])) << 48) | ((uint64_t)((uint8_t)(v[7])) << 56);
}
NS_INLINE uint64_t fetch64(const char *p, const uint64_t v)
METAXXHASHUTILS_INLINE_ATTRS
uint64_t fetch64(const char *p, const uint64_t v)
{
return mix2(endian64(p), v);
}
NS_INLINE uint64_t fetch32(const char *p)
METAXXHASHUTILS_INLINE_ATTRS
uint64_t fetch32(const char *p)
{
return (uint64_t)(endian32(p)) * PRIME1;
return (uint64_t)(endian32(p)) * METAXXHASHUTILS_PRIME_1;
}
NS_INLINE uint64_t fetch8(const char *p)
METAXXHASHUTILS_INLINE_ATTRS
uint64_t fetch8(const char *p)
{
return (uint8_t)(*p) * PRIME5;
return (uint8_t)(*p) * METAXXHASHUTILS_PRIME_5;
}
NS_INLINE uint64_t finalize(const uint64_t h, const char *p, uint64_t len)
METAXXHASHUTILS_INLINE_ATTRS
uint64_t finalize(const uint64_t h, const char *p, uint64_t len)
{
return (len >= 8) ? (finalize(rotl(h ^ fetch64(p, 0), 27) * PRIME1 + PRIME4, p + 8, len - 8))
: ((len >= 4) ? (finalize(rotl(h ^ fetch32(p), 23) * PRIME2 + PRIME3, p + 4, len - 4))
: ((len > 0) ? (finalize(rotl(h ^ fetch8(p), 11) * PRIME1, p + 1, len - 1))
: (mix1(mix1(mix1(h, PRIME2, 33), PRIME3, 29), 1, 32))));
return (len >= 8) ? (finalize(rotl(h ^ fetch64(p, 0), 27) * METAXXHASHUTILS_PRIME_1 + METAXXHASHUTILS_PRIME_4, p + 8, len - 8))
: ((len >= 4) ? (finalize(rotl(h ^ fetch32(p), 23) * METAXXHASHUTILS_PRIME_2 + METAXXHASHUTILS_PRIME_3, p + 4, len - 4))
: ((len > 0) ? (finalize(rotl(h ^ fetch8(p), 11) * METAXXHASHUTILS_PRIME_1, p + 1, len - 1))
: (mix1(mix1(mix1(h, METAXXHASHUTILS_PRIME_2, 33), METAXXHASHUTILS_PRIME_3, 29), 1, 32))));
}
NS_INLINE uint64_t h32bytes_compute(const char *p, uint64_t len, const uint64_t v1, const uint64_t v2, const uint64_t v3, const uint64_t v4)
METAXXHASHUTILS_INLINE_ATTRS
uint64_t h32bytes_compute(const char *p, uint64_t len, const uint64_t v1, const uint64_t v2, const uint64_t v3, const uint64_t v4)
{
return (len >= 32) ? h32bytes_compute(p + 32, len - 32, fetch64(p, v1), fetch64(p + 8, v2), fetch64(p + 16, v3), fetch64(p + 24, v4))
: mix3(mix3(mix3(mix3(rotl(v1, 1) + rotl(v2, 7) + rotl(v3, 12) + rotl(v4, 18), v1), v2), v3), v4);
}
NS_INLINE uint64_t h32bytes(const char *p, uint64_t len, const uint64_t seed)
METAXXHASHUTILS_INLINE_ATTRS
uint64_t h32bytes(const char *p, uint64_t len, const uint64_t seed)
{
return h32bytes_compute(p, len, seed + PRIME1 + PRIME2, seed + PRIME2, seed, seed - PRIME1);
return h32bytes_compute(p, len, seed + METAXXHASHUTILS_PRIME_1 + METAXXHASHUTILS_PRIME_2, seed + METAXXHASHUTILS_PRIME_2, seed, seed - METAXXHASHUTILS_PRIME_1);
}
/*
Primary APIs
*/
NS_INLINE uint64_t meta_xxhash64(const char *p, uint64_t len, uint64_t seed)
METAXXHASHUTILS_INLINE_ATTRS
uint64_t meta_xxhash64(const char *p, uint64_t len, uint64_t seed)
{
return finalize((len >= 32 ? h32bytes(p, len, seed) : seed + PRIME5) + len, p + (len & ~0x1FULL), len & 0x1FULL);
return finalize((len >= 32 ? h32bytes(p, len, seed) : seed + METAXXHASHUTILS_PRIME_5) + len, p + (len & ~0x1FULL), len & 0x1FULL);
}
NS_INLINE uint64_t FBxxHash64(const char *p, uint64_t len, uint64_t seed)
METAXXHASHUTILS_INLINE_ATTRS
uint64_t FBxxHash64(const char *p, uint64_t len, uint64_t seed)
{
return meta_xxhash64(p, len, seed);
}