Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Undo breaking change on getJsCallInvokerHolder (#45376)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/45376

This reduces one breaking change users are seeing on `CatalystInstance.getJsCallInvokerHolder`.
I had to specify:

```
Suppress("INAPPLICABLE_JVM_NAME")
get:JvmName("getJSCallInvokerHolder")
```

as the Kotlin compiler is unhappy with me setting a JvmName on a interface property.
More on this here: https://youtrack.jetbrains.com/issue/KT-31420

Changelog:
[Android] [Fixed] - Undo breaking change on `CatalystInstance.getJsCallInvokerHolder`

Reviewed By: javache

Differential Revision: D59631640

fbshipit-source-id: 4d5b3499e4e0e0bec1d380c4b7942ea28ae35465
This commit is contained in:
Nicola Corti
2024-07-11 07:45:55 -07:00
committed by Facebook GitHub Bot
parent 33262c1717
commit 2ea9c360dc
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstance.kt
+4 -1
View File
@@ -106,7 +106,10 @@ public interface CatalystInstance : MemoryPressureListener, JSInstance, JSBundle
* Returns a hybrid object that contains a pointer to a JS CallInvoker, which is used to schedule
* work on the JS Thread. Required for TurboModuleManager initialization.
*/
@get:Deprecated("") public val jSCallInvokerHolder: CallInvokerHolder
@get:Deprecated("Use ReactContext.getJSCallInvokerHolder instead")
@Suppress("INAPPLICABLE_JVM_NAME")
@get:JvmName("getJSCallInvokerHolder") // This is needed to keep backward compatibility
public val jsCallInvokerHolder: CallInvokerHolder
/**
* Returns a hybrid object that contains a pointer to a NativeMethodCallInvoker, which is used to
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/BridgelessCatalystInstance.kt
+3 -1
View File
@@ -90,7 +90,9 @@ public class BridgelessCatalystInstance(private val reactHost: ReactHostImpl) :
override public val javaScriptContextHolder: JavaScriptContextHolder
get() = reactHost.getJavaScriptContextHolder()!!
override public val jSCallInvokerHolder: CallInvokerHolder
@Suppress("INAPPLICABLE_JVM_NAME")
@get:JvmName("getJSCallInvokerHolder") // This is needed to keep backward compatibility
override public val jsCallInvokerHolder: CallInvokerHolder
get() = reactHost.getJSCallInvokerHolder()!!
override public val nativeMethodCallInvokerHolder: NativeMethodCallInvokerHolder