mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Remove prettier from dependencies (#33125)
Summary: `prettier` should not be declared in dependencies in the ESLint config because it can trigger issues when a different version is installed on the client app. `prettier` is already declared as `peerDependencies` and in the [README](https://github.com/facebook/react-native/blob/main/packages/eslint-config-react-native-community/README.md), it's explicitly asked to install it: ``` yarn add --dev eslint prettier react-native-community/eslint-config ``` ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Fixed] - Remove prettier from dependencies in eslint-config Pull Request resolved: https://github.com/facebook/react-native/pull/33125 Test Plan: - Install the package `react-native-community/eslint-config` and ensure everything works the same as before Reviewed By: yungsters Differential Revision: D34305118 Pulled By: ShikaSD fbshipit-source-id: 65a3a79008cd5e28cc6aa93ef4a5032990b4e9f8
This commit is contained in:
committed by
Facebook GitHub Bot
parent
35800962c1
commit
2db1bca952
@@ -22,8 +22,7 @@
|
||||
"eslint-plugin-prettier": "^4.0.0",
|
||||
"eslint-plugin-react": "^7.26.1",
|
||||
"eslint-plugin-react-hooks": "^4.2.0",
|
||||
"eslint-plugin-react-native": "^3.11.0",
|
||||
"prettier": "^2.4.1"
|
||||
"eslint-plugin-react-native": "^3.11.0"
|
||||
},
|
||||
"peerDependencies": {
|
||||
"eslint": ">=7",
|
||||
|
||||
Reference in New Issue
Block a user