mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
fix: Register HeadlessJsTaskSupportModule in CoreReactPackage (#56267)
Summary: The `HeadlessJsTaskSupportModule` was not included in any ReactPackage, causing `AppRegistry.notifyTaskFinished()` to fail silently. This meant headless JS tasks would not properly signal completion to the calling service, leaving it to linger unnecessarily. This fix adds `HeadlessJsTaskSupportModule` to `CoreReactPackage` so that `notifyTaskFinished` and `notifyTaskRetry` methods are properly available. ## Changelog [ANDROID] [FIXED] - Register HeadlessJsTaskSupportModule in CoreReactPackage Pull Request resolved: https://github.com/facebook/react-native/pull/56267 Test Plan: - [x] Android Kotlin compilation passes - [ ] Verify headless JS tasks can properly call `notifyTaskFinished()` Fixes https://github.com/facebook/react-native/issues/56263 🤖 Generated with [Claude Code](https://claude.com/claude-code) Reviewed By: fabriziocucci Differential Revision: D98884467 Pulled By: cortinico fbshipit-source-id: 0e1e88e722d0d353d0469a46fbddda9f11e3c81a
This commit is contained in:
1 parent
664acaf441
commit
2d78a39b3e
1 file changed
+4
+4
@@ -20,6 +20,7 @@ import com.facebook.react.module.model.ReactModuleInfoProvider
|
||||
import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler
|
||||
import com.facebook.react.modules.core.DeviceEventManagerModule
|
||||
import com.facebook.react.modules.core.ExceptionsManagerModule
|
||||
import com.facebook.react.modules.core.HeadlessJsTaskSupportModule
|
||||
import com.facebook.react.modules.debug.DevMenuModule
|
||||
import com.facebook.react.modules.debug.DevSettingsModule
|
||||
import com.facebook.react.modules.debug.SourceCodeModule
|
||||
@@ -38,6 +39,7 @@ import java.util.HashMap
|
||||
LogBoxModule::class,
|
||||
DeviceEventManagerModule::class,
|
||||
ExceptionsManagerModule::class,
|
||||
HeadlessJsTaskSupportModule::class,
|
||||
]
|
||||
)
|
||||
internal class CoreReactPackage(
|
||||
@@ -57,6 +59,7 @@ internal class CoreReactPackage(
|
||||
|
||||
LogBoxModule.NAME -> LogBoxModule(reactContext, devSupportManager)
|
||||
ExceptionsManagerModule.NAME -> ExceptionsManagerModule(devSupportManager)
|
||||
HeadlessJsTaskSupportModule.NAME -> HeadlessJsTaskSupportModule(reactContext)
|
||||
else -> null
|
||||
}
|
||||
|
||||
@@ -96,6 +99,7 @@ internal class CoreReactPackage(
|
||||
DeviceEventManagerModule::class.java,
|
||||
LogBoxModule::class.java,
|
||||
ExceptionsManagerModule::class.java,
|
||||
HeadlessJsTaskSupportModule::class.java,
|
||||
)
|
||||
val reactModuleInfoMap: MutableMap<String, ReactModuleInfo> = HashMap()
|
||||
for (moduleClass in moduleList) {
|
||||
|
||||
Reference in new issue
Block a user