Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update ios pod post_install logic for detecting if hermes is enabled (#41286)

Browse Source 
Summary:
Follow up of https://github.com/facebook/react-native/pull/41284#issuecomment-1789516046

We should not rely on  checking if the `React-hermes` pod is present to determine if hermes is enabled

## Changelog:

[IOS] [CHANGED] - Update ios pod post_install logic for detecting if hermes is enabled

Pull Request resolved: https://github.com/facebook/react-native/pull/41286

Test Plan: Run `use_react_native!(hermes => false)` should not add `USE_HERMES = true;` to `project.pbxproj`

Reviewed By: blakef

Differential Revision: D50899654

Pulled By: cipolleschi

fbshipit-source-id: a5ab5b0117c61014e77b780c50bf349da92c6342
This commit is contained in:
Gabriel Donadel
2024-01-02 10:25:39 +00:00
committed by Alex Hunt
parent cadcf541fa
commit 2c8aa68600
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/scripts/react_native_pods.rb
+1 -1
View File
@@ -294,7 +294,7 @@ def react_native_post_install(
end
fabric_enabled = ENV['RCT_FABRIC_ENABLED'] == '1'
hermes_enabled = ReactNativePodsUtils.has_pod(installer, "React-hermes")
hermes_enabled = ENV['USE_HERMES'] == '1'
if hermes_enabled
ReactNativePodsUtils.set_gcc_preprocessor_definition_for_React_hermes(installer)