Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Differ: comments

Browse Source 
Summary:
Just adding a comment for future possible refactoring here.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D28003338

fbshipit-source-id: ec307314d18d69f8c77c2b2afff1f3953ca55473
This commit is contained in:
Joshua Gross
2021-04-26 11:59:11 -07:00
committed by Facebook GitHub Bot
parent 1b83922cb6
commit 2c62e02b2b
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/react/renderer/mounting/Differentiator.cpp
+4
View File
@@ -753,6 +753,10 @@ static void calculateShadowViewMutationsFlattener(
continue;
}
// TODO: compare ShadowNode pointer instead of ShadowView here?
// Or ShadowNode ptr comparison before comparing ShadowView, to allow for
// short-circuiting? ShadowView comparison is relatively expensive vs
// ShadowNode.
if (newTreeNodePair.shadowView != oldTreeNodePair.shadowView &&
newTreeNodePair.isConcreteView && oldTreeNodePair.isConcreteView) {
mutationContainer.updateMutations.push_back(