Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert D17793693: [RN] Add debug message to RCTShadowView when we insert a subview incorrectly

Browse Source 
Differential Revision:
D17793693

Original commit changeset: 848ae658200e

fbshipit-source-id: e59299f596f95e2bea978b07cd7e8f1de345708a
This commit is contained in:
Mehdi Mulani
2019-10-09 12:15:13 -07:00
committed by Facebook Github Bot
parent 6611c4b8f4
commit 2a3fa968b4
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/Views/RCTShadowView.m
-9
View File
@@ -227,15 +227,6 @@ static void RCTProcessMetaPropsBorder(const YGValue metaProps[META_PROP_COUNT],
{
RCTAssert(self.canHaveSubviews, @"Attempt to insert subview inside leaf view.");
// TODO(T55181688): Delete after getting crashes with a view hierarchy.
if (atIndex > [_reactSubviews count]) {
RCTShadowView *ancestor = self;
for (NSInteger i = 0; i < 5 && [ancestor superview]; i++) {
ancestor = [ancestor superview];
}
RCTAssert(NO, @"Tried to insert subview on view %@ with ancestor description %@", self, ancestor);
}
[_reactSubviews insertObject:subview atIndex:atIndex];
if (![self isYogaLeafNode]) {
YGNodeInsertChild(_yogaNode, subview.yogaNode, (uint32_t)atIndex);