mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Remove unnecessary $FlowFixMe after correct typing for console.timeStamp (#52633)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/52633 Changelog: [internal] Now that we have the correct type definition for `console.timeStamp` we can remove the unnecessary `$FlowFixMe` annotations we had to add to use the new arguments. Reviewed By: hoxyq Differential Revision: D78405312 fbshipit-source-id: 29378ee6fa5986e22d0dfdfb85b7e25375361dc9
This commit is contained in:
committed by
Facebook GitHub Bot
parent
c247554342
commit
2a01eadcb8
@@ -26,7 +26,6 @@ describe('console.timeStamp()', () => {
|
||||
|
||||
it("doesn't throw when additional arguments are specified", () => {
|
||||
expect(() =>
|
||||
// $FlowExpectedError[extra-arg]
|
||||
console.timeStamp('label', 100, 500, 'Track', 'Group', 'error'),
|
||||
).not.toThrow();
|
||||
});
|
||||
@@ -35,7 +34,6 @@ describe('console.timeStamp()', () => {
|
||||
// $FlowExpectedError[incompatible-call]
|
||||
expect(() => console.timeStamp({})).not.toThrow();
|
||||
expect(() =>
|
||||
// $FlowExpectedError[extra-arg]
|
||||
// $FlowExpectedError[incompatible-call]
|
||||
console.timeStamp('label', true, null, {}, [], () => {}),
|
||||
).not.toThrow();
|
||||
|
||||
@@ -400,7 +400,6 @@ class XMLHttpRequest extends EventTarget {
|
||||
if (XMLHttpRequest._profiling) {
|
||||
console.timeStamp(
|
||||
'Incremental Data: ' + this._getMeasureURL(),
|
||||
// $FlowFixMe[extra-arg] Add correct typing for `console.timeStamp`
|
||||
start,
|
||||
undefined,
|
||||
PERFORMANCE_TRACK_NAME,
|
||||
@@ -455,7 +454,6 @@ class XMLHttpRequest extends EventTarget {
|
||||
const start = this._startTime;
|
||||
console.timeStamp(
|
||||
this._getMeasureURL(),
|
||||
// $FlowFixMe[extra-arg] Add correct typing for `console.timeStamp`
|
||||
start,
|
||||
undefined,
|
||||
PERFORMANCE_TRACK_NAME,
|
||||
|
||||
Reference in New Issue
Block a user