mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
fix(android): pin react-android aarMetadata.minCompileSdk to 34 (#57289)
Summary: AGP 9 changed the default so a library propagates a minCompileSdk equal to its own compileSdk. Since react-android compiles against compileSdk 36, this now forces every consuming library/app to compileSdk >= 36 (e.g. it breaks libraries still on compileSdk 35 at checkAarMetadata). RN does not actually require API 36: its public ABI exposes no android type newer than ~API 23, the highest framework constant referenced in code is UPSIDE_DOWN_CAKE (34), and the source is deliberately written to compile against SDK 34 (see util/AndroidVersion.kt, which abstracts the 35/36 version codes and the API-35 windowOptOutEdgeToEdgeEnforcement attribute). compileSdk is 36 only to build against the latest platform. Set minCompileSdk = 34 explicitly to restore the pre-AGP-9 behavior and avoid needlessly forcing the library ecosystem onto compileSdk 36. The binary-compatibility-validator dump (ReactAndroid.api) guards against future regressions: adding an API 35/36 type to the public ABI would change that file and signal that this floor must rise. ## Changelog: [ANDROID] [CHANGED] - Set minCompileSdk to 34, libraries will have to specify a compileSdk of >= 34 in order to work with React Native Pull Request resolved: https://github.com/react/react-native/pull/57289 Test Plan: CI Reviewed By: javache Differential Revision: D109154415 Pulled By: cortinico fbshipit-source-id: f25e0a1992c450bfab83211ea6245375858b8895
This commit is contained in:
1 parent
c6110b1a3f
commit
29e5f954c7
1 file changed
+9
@@ -553,6 +553,15 @@ android {
|
||||
defaultConfig {
|
||||
minSdk = libs.versions.minSdk.get().toInt()
|
||||
|
||||
aarMetadata {
|
||||
// RN's public ABI exposes no android API newer than 34, and the source is written to
|
||||
// compile against SDK 34 (see util/AndroidVersion.kt). compileSdk is 36 only to build
|
||||
// against the latest platform — it is not an API requirement. Without this, AGP 9
|
||||
// defaults minCompileSdk to compileSdk (36), needlessly forcing every consuming
|
||||
// library/app to compileSdk 36.
|
||||
minCompileSdk = 34
|
||||
}
|
||||
|
||||
consumerProguardFiles("proguard-rules.pro")
|
||||
|
||||
buildConfigField("boolean", "IS_INTERNAL_BUILD", "false")
|
||||
|
||||
Reference in new issue
Block a user