Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Explicitly set mBinding to null in FabricUIManager

Browse Source 
Summary: Although `mBinding` is unregistered which means the connection to the JNI-bridged Cxx object can be destructed, we still hold onto the `mBinding` Java object after unregistering. That doesn't seem desirable, I think we should just clear it out here for consistency.

Reviewed By: mdvacca

Differential Revision: D17865206

fbshipit-source-id: 1ad8643c48ba0b2d52620a7b8ebe8a52928648ef
This commit is contained in:
Joshua Gross
2019-10-10 20:36:56 -07:00
committed by Facebook Github Bot
parent c82e27030c
commit 299eb9f440
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java
+1
View File
@@ -212,6 +212,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
mEventDispatcher.removeBatchEventDispatchedListener(mEventBeatManager);
mEventDispatcher.unregisterEventEmitter(FABRIC);
mBinding.unregister();
mBinding = null;
ViewManagerPropertyUpdater.clear();
}