From 299eb9f440fff7c7330e40e9e927e50beab4b60e Mon Sep 17 00:00:00 2001 From: Joshua Gross Date: Thu, 10 Oct 2019 20:34:49 -0700 Subject: [PATCH] Explicitly set mBinding to null in FabricUIManager Summary: Although `mBinding` is unregistered which means the connection to the JNI-bridged Cxx object can be destructed, we still hold onto the `mBinding` Java object after unregistering. That doesn't seem desirable, I think we should just clear it out here for consistency. Reviewed By: mdvacca Differential Revision: D17865206 fbshipit-source-id: 1ad8643c48ba0b2d52620a7b8ebe8a52928648ef --- .../src/main/java/com/facebook/react/fabric/FabricUIManager.java | 1 + 1 file changed, 1 insertion(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java index 5ea7fa5b7fa..c37b46c738e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java @@ -212,6 +212,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener { mEventDispatcher.removeBatchEventDispatchedListener(mEventBeatManager); mEventDispatcher.unregisterEventEmitter(FABRIC); mBinding.unregister(); + mBinding = null; ViewManagerPropertyUpdater.clear(); }