Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optional verbose logging for LayoutAnimations

Browse Source 
Summary:
I've used this while debugging LayoutAnimations a few times. It compiles out to nothing when the define is not set.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D22962113

fbshipit-source-id: 88b7bb1c20a07a7d804e5c81d31cf871d58bee92
This commit is contained in:
Joshua Gross
2020-08-05 17:44:06 -07:00
committed by Facebook GitHub Bot
parent 1b575e8d1f
commit 28ff63f669
2 changed files with 81 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.cpp
+75
View File
@@ -30,6 +30,50 @@
namespace facebook {
namespace react {
#ifdef LAYOUT_ANIMATION_VERBOSE_LOGGING
static void PrintMutationInstruction(
std::string message,
ShadowViewMutation const &mutation) {
bool mutationIsRemove = mutation.type == ShadowViewMutation::Type::Remove;
bool mutationIsInsert = mutation.type == ShadowViewMutation::Type::Insert;
LOG(ERROR) << message << " Mutation: "
<< (mutationIsInsert ? "INSERT"
: (mutationIsRemove ? "REMOVE" : "OTHER"))
<< (mutationIsInsert ? mutation.newChildShadowView.tag
: mutation.oldChildShadowView.tag)
<< "->" << mutation.parentShadowView.tag << " " << mutation.index;
}
static void PrintMutationInstructionRelative(
std::string message,
ShadowViewMutation const &mutation,
ShadowViewMutation const &relativeMutation) {
bool mutationIsRemove = mutation.type == ShadowViewMutation::Type::Remove;
bool mutationIsInsert = mutation.type == ShadowViewMutation::Type::Insert;
bool relativeMutationIsRemove =
relativeMutation.type == ShadowViewMutation::Type::Remove;
bool relativeMutationIsInsert =
relativeMutation.type == ShadowViewMutation::Type::Insert;
LOG(ERROR) << message << " Mutation: "
<< (mutationIsInsert ? "INSERT"
: (mutationIsRemove ? "REMOVE" : "OTHER"))
<< (mutationIsInsert ? mutation.newChildShadowView.tag
: mutation.oldChildShadowView.tag)
<< "->" << mutation.parentShadowView.tag << " " << mutation.index
<< " RelativeMutation: "
<< (relativeMutationIsInsert
? "INSERT"
: (relativeMutationIsRemove ? "REMOVE" : "OTHER"))
<< (relativeMutationIsInsert
? relativeMutation.newChildShadowView.tag
: relativeMutation.oldChildShadowView.tag)
<< "->" << relativeMutation.parentShadowView.tag << " "
<< relativeMutation.index;
}
#else
#define PrintMutationInstruction(a, b)
#define PrintMutationInstructionRelative(a, b, c)
#endif
static better::optional<AnimationType> parseAnimationType(std::string param) {
if (param == "spring") {
return better::optional<AnimationType>(AnimationType::Spring);
@@ -357,6 +401,9 @@ void LayoutAnimationKeyFrameManager::
// TODO: turn all of this into a lambda and share code?
if (mutatedViewIsVirtual(mutation)) {
PrintMutationInstruction(
"[IndexAdjustment] Not calling adjustImmediateMutationIndicesForDelayedMutations, is virtual, for:",
mutation);
return;
}
@@ -391,6 +438,10 @@ void LayoutAnimationKeyFrameManager::
if (finalAnimationMutation.index < mutation.index) {
mutation.index++;
PrintMutationInstructionRelative(
"[IndexAdjustment] adjustImmediateMutationIndicesForDelayedMutations: Adjusting mutation UPWARD",
mutation,
finalAnimationMutation);
}
}
}
@@ -404,6 +455,9 @@ void LayoutAnimationKeyFrameManager::adjustDelayedMutationIndicesForMutation(
assert(isRemoveMutation || isInsertMutation);
if (mutatedViewIsVirtual(mutation)) {
PrintMutationInstruction(
"[IndexAdjustment] Not calling adjustDelayedMutationIndicesForMutation, is virtual, for:",
mutation);
return;
}
@@ -440,10 +494,18 @@ void LayoutAnimationKeyFrameManager::adjustDelayedMutationIndicesForMutation(
if (isRemoveMutation) {
if (mutation.index <= finalAnimationMutation.index) {
finalAnimationMutation.index--;
PrintMutationInstructionRelative(
"[IndexAdjustment] adjustImmediateMutationIndicesForDelayedMutations: Adjusting mutation DOWNWARD",
mutation,
finalAnimationMutation);
}
} else if (isInsertMutation) {
if (mutation.index <= finalAnimationMutation.index) {
finalAnimationMutation.index++;
PrintMutationInstructionRelative(
"[IndexAdjustment] adjustImmediateMutationIndicesForDelayedMutations: Adjusting mutation UPWARD",
mutation,
finalAnimationMutation);
}
}
}
@@ -674,6 +736,11 @@ LayoutAnimationKeyFrameManager::pullTransaction(
surfaceId, mutation);
}
if (mutation.type == ShadowViewMutation::Remove) {
PrintMutationInstruction(
"Queueing immediate execution of Remove mutation", mutation);
}
immediateMutations.push_back(mutation);
// Adjust indices for any non-directly-conflicting animations that
@@ -818,12 +885,20 @@ LayoutAnimationKeyFrameManager::pullTransaction(
if (otherMutation.index <= adjustedIndex) {
adjustedIndex++;
adjustment++;
PrintMutationInstructionRelative(
"[IndexAdjustment][2] Adjusting index upward for delayed remove",
mutation,
otherMutation);
} else {
// If we are delaying this remove instruction, conversely,
// we must adjust upward the insertion index of any INSERT
// instructions if the View is insert *after* this view in
// the hierarchy.
otherMutation.index++;
PrintMutationInstructionRelative(
"[IndexAdjustment][3] Adjusting index upward for other (Insert)",
mutation,
otherMutation);
}
}
}
ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h
+6
View File
@@ -7,6 +7,12 @@
#pragma once
// Enable some or all of these to enable very verbose logging for
// LayoutAnimations
//#define LAYOUT_ANIMATION_VERBOSE_LOGGING 1
//#define RN_SHADOW_TREE_INTROSPECTION
//#define RN_DEBUG_STRING_CONVERTIBLE 1
#include <ReactCommon/RuntimeExecutor.h>
#include <better/optional.h>
#include <react/renderer/core/EventTarget.h>