Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix lookup of ReactModuleInfoProvider for CoreReactPackage (#41086)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/41086

In this diff I'm fixing the lookup of ReactModuleInfoProvider instance for CoreReactPackage. It is searching for the wrong class.

changelog: [internal] internal

Reviewed By: RSNara

Differential Revision: D50338304

fbshipit-source-id: 840d1d018cc0f9df8a64fd09a851d8a87f5a1f15
This commit is contained in:
David Vacca
2023-10-20 15:24:09 -07:00
committed by Facebook GitHub Bot
parent 97f73a01c3
commit 28d7adea7e
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/CoreReactPackage.java
+11 -5
View File
@@ -41,8 +41,8 @@ import java.util.Map;
})
class CoreReactPackage extends TurboReactPackage {
private DevSupportManager mDevSupportManager;
private DefaultHardwareBackBtnHandler mHardwareBackBtnHandler;
private final DevSupportManager mDevSupportManager;
private final DefaultHardwareBackBtnHandler mHardwareBackBtnHandler;
public CoreReactPackage(
DevSupportManager devSupportManager, DefaultHardwareBackBtnHandler hardwareBackBtnHandler) {
@@ -77,7 +77,7 @@ class CoreReactPackage extends TurboReactPackage {
public ReactModuleInfoProvider getReactModuleInfoProvider() {
try {
Class<?> reactModuleInfoProviderClass =
Class.forName("com.facebook.react.CoreModulesPackage$$ReactModuleInfoProvider");
Class.forName(CoreReactPackage.class.getName() + "$$ReactModuleInfoProvider");
return (ReactModuleInfoProvider) reactModuleInfoProviderClass.newInstance();
} catch (ClassNotFoundException e) {
// In OSS case, the annotation processor does not run. We fall back on creating this byhand
@@ -109,10 +109,16 @@ class CoreReactPackage extends TurboReactPackage {
return () -> reactModuleInfoMap;
} catch (InstantiationException e) {
throw new RuntimeException(
"No ReactModuleInfoProvider for CoreModulesPackage$$ReactModuleInfoProvider", e);
"No ReactModuleInfoProvider for "
+ CoreReactPackage.class.getName()
+ "$$ReactModuleInfoProvider",
e);
} catch (IllegalAccessException e) {
throw new RuntimeException(
"No ReactModuleInfoProvider for CoreModulesPackage$$ReactModuleInfoProvider", e);
"No ReactModuleInfoProvider for "
+ CoreReactPackage.class.getName()
+ "$$ReactModuleInfoProvider",
e);
}
}
}