LogBox - Display code frame column number correctly

Summary:
Code frame columns are returned 0 based but displayed in editors 1 based, this diff bumps the column we display by one to match.

Changelog: [Internal]

Reviewed By: cpojer

Differential Revision: D18426163

fbshipit-source-id: 2c6aefb6fe7ce161cd768b6748b7739d486ed438

Libraries/LogBox/UI/LogBoxInspectorCodeFrame.js

@@ -62,7 +62,9 @@ function LogBoxInspectorCodeFrame(props: Props): React.Node {
           }}>
           <Text style={styles.fileText}>
             {getFileName()} ({codeFrame.location.row}:
-            {codeFrame.location.column})
+            {codeFrame.location.column +
+              1 /* Code frame columns are zero indexed */}
+            )
           </Text>
         </LogBoxButton>
       </View>

Libraries/LogBox/UI/LogBoxInspectorStackFrame.js

@@ -65,11 +65,12 @@ function formatFrameLocation(frame: StackFrame): string {
 
   location = location + ':' + lineNumber;
 
-  if (column == null) {
+  if (column == null || isNaN(parseInt(column, 10))) {
     return location;
   }
 
-  return location + ':' + column;
+  // Stack frame columns are zero indexed but editors start at one.
+  return location + ':' + (parseInt(column, 10) + 1);
 }
 
 const styles = StyleSheet.create({

Libraries/LogBox/UI/__tests__/__snapshots__/LogBoxInspectorCodeFrame-test.js.snap

@@ -109,7 +109,7 @@ exports[`LogBoxInspectorCodeFrame should render a code frame 1`] = `
          (
         199
         :
-        0
+        1
         )
       </Text>
     </LogBoxButton>

Libraries/LogBox/UI/__tests__/__snapshots__/LogBoxInspectorStackFrame-test.js.snap

@@ -52,7 +52,7 @@ exports[`LogBoxInspectorStackFrame should render collapsed stack frame with dimm
       ]
     }
   >
-    app.js:1:1
+    app.js:1:2
   </Text>
 </LogBoxButton>
 `;
@@ -105,7 +105,7 @@ exports[`LogBoxInspectorStackFrame should render stack frame 1`] = `
       ]
     }
   >
-    app.js:1:1
+    app.js:1:2
   </Text>
 </LogBoxButton>
 `;