Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix lints in FabricUIManager (#42970)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/42970

Fix lints in FabricUIManager

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53636010

fbshipit-source-id: caab6821377b1bde11d2bed9cc2ef13283b8185f
This commit is contained in:
David Vacca
2024-02-12 15:38:15 -08:00
committed by Facebook GitHub Bot
parent 8cd6f39024
commit 282127d6e0
2 changed files with 17 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/Binding.java
+12 -13
View File
@@ -17,10 +17,9 @@ import com.facebook.react.fabric.events.EventEmitterWrapper;
public interface Binding {
public void startSurface(
int surfaceId, @NonNull String moduleName, @NonNull NativeMap initialProps);
void startSurface(int surfaceId, @NonNull String moduleName, @NonNull NativeMap initialProps);
public void startSurfaceWithConstraints(
void startSurfaceWithConstraints(
int surfaceId,
String moduleName,
NativeMap initialProps,
@@ -33,11 +32,11 @@ public interface Binding {
boolean isRTL,
boolean doLeftAndRightSwapInRTL);
public void stopSurface(int surfaceId);
void stopSurface(int surfaceId);
public void setPixelDensity(float pointScaleFactor);
void setPixelDensity(float pointScaleFactor);
public void setConstraints(
void setConstraints(
int surfaceId,
float minWidth,
float maxWidth,
@@ -48,13 +47,13 @@ public interface Binding {
boolean isRTL,
boolean doLeftAndRightSwapInRTL);
public void driveCxxAnimations();
void driveCxxAnimations();
public void reportMount(int surfaceId);
void reportMount(int surfaceId);
public ReadableNativeMap getInspectorDataForInstance(EventEmitterWrapper eventEmitterWrapper);
ReadableNativeMap getInspectorDataForInstance(EventEmitterWrapper eventEmitterWrapper);
public void register(
void register(
@NonNull RuntimeExecutor runtimeExecutor,
@NonNull RuntimeScheduler runtimeScheduler,
@NonNull FabricUIManager fabricUIManager,
@@ -62,9 +61,9 @@ public interface Binding {
@NonNull ComponentFactory componentFactory,
@NonNull ReactNativeConfig reactNativeConfig);
public void unregister();
void unregister();
public void registerSurface(SurfaceHandlerBinding surfaceHandler);
void registerSurface(SurfaceHandlerBinding surfaceHandler);
public void unregisterSurface(SurfaceHandlerBinding surfaceHandler);
void unregisterSurface(SurfaceHandlerBinding surfaceHandler);
}
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java
+5 -5
View File
@@ -675,12 +675,11 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
return View.NO_ID;
}
@NonNull
@Override
public String toString() {
String propsString =
IS_DEVELOPMENT_ENVIRONMENT
? (props != null ? props.toHashMap().toString() : "<null>")
: "<hidden>";
IS_DEVELOPMENT_ENVIRONMENT ? props.toHashMap().toString() : "<hidden>";
return String.format("SYNC UPDATE PROPS [%d]: %s", reactTag, propsString);
}
};
@@ -972,7 +971,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
}
private void postChoreographerCallbackIfNecessary() {
if (ReactFeatureFlags.enableOnDemandReactChoreographer == false) {
if (!ReactFeatureFlags.enableOnDemandReactChoreographer) {
return;
}
@@ -1159,6 +1158,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
return View.NO_ID;
}
@NonNull
@Override
public String toString() {
return "CLEAR_JS_RESPONDER";
@@ -1245,7 +1245,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
}
// Collect surface IDs for all the mount items
List<Integer> surfaceIds = new ArrayList();
List<Integer> surfaceIds = new ArrayList<>();
for (MountItem mountItem : mountItems) {
if (mountItem != null && !surfaceIds.contains(mountItem.getSurfaceId())) {
surfaceIds.add(mountItem.getSurfaceId());