mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
fix: role="searchbox" should assing "SearchField" trait on iOS (#39314)
Summary: Experimenting with Accessibility Inspector on iOS I've discovered that while when assigning `accessibilityRole="searchbox"` to a text input results in "Traits" reporting "Search Field" trait. However, when using ARIA-compatible `role="search"` such trait is not assigned, and text input will have an empty trait. Afaiu this is incorrect as using `role="search"` and `accessibilityRole="searchbox"` should equivalent effect. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> IOS FIXED - `role="searchbox"` now assigns "Search Field" accessibility trait to a view Pull Request resolved: https://github.com/facebook/react-native/pull/39314 Test Plan: No UI changes, it affects only accessibility. Reviewed By: NickGerleman Differential Revision: D49014039 Pulled By: dmytrorykun fbshipit-source-id: 5fb194e67fbf2ac339d9a746e3ce6aaed2d32558
This commit is contained in:
committed by
Facebook GitHub Bot
parent
ef3e771a23
commit
2749fbca9a
@@ -92,7 +92,7 @@ RCT_MULTI_ENUM_CONVERTER(
|
||||
@"scrollbar" : @(UIAccessibilityTraitNone),
|
||||
@"scrollview" : @(UIAccessibilityTraitNone),
|
||||
@"search" : @(UIAccessibilityTraitSearchField),
|
||||
@"searchbox" : @(UIAccessibilityTraitNone),
|
||||
@"searchbox" : @(UIAccessibilityTraitSearchField),
|
||||
@"selected" : @(UIAccessibilityTraitSelected),
|
||||
@"separator" : @(UIAccessibilityTraitNone),
|
||||
@"slider" : @(UIAccessibilityTraitNone),
|
||||
|
||||
Reference in New Issue
Block a user