Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove __REACT_DEVTOOLS_GLOBAL_HOOK__ from react-native libdef (#50223)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/50223

This is an implementation detail of React and better not make it leak everywhere. It's not used quite often even in react-native codebase, so it's better to just suppress the error on each call site. Currently it's typed as any, so there is not much type safety lost anyways.

Changelog: [Internal]

Reviewed By: alexmckenley

Differential Revision: D71687426

fbshipit-source-id: 7373bcd9bedcfcb95a10fa02e6a04399ccab91f0
This commit is contained in:
Sam Zhou
2025-03-24 12:31:58 -07:00
committed by Facebook GitHub Bot
parent 2cb49eeaa3
commit 26ca802e84
4 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/Debugging/DebuggingOverlayRegistry.js
Vendored
+2 -2
View File
@@ -35,8 +35,8 @@ import processColor from '../StyleSheet/processColor';
// TODO(T171193075): __REACT_DEVTOOLS_GLOBAL_HOOK__ is always injected in dev-bundles,
// but it is not mocked in some Jest tests. We should update Jest tests setup, so it would be the same as expected testing environment.
const reactDevToolsHook: ?ReactDevToolsGlobalHook =
window.__REACT_DEVTOOLS_GLOBAL_HOOK__;
const reactDevToolsHook: ?ReactDevToolsGlobalHook = (window: $FlowFixMe)
.__REACT_DEVTOOLS_GLOBAL_HOOK__;
export type DebuggingOverlayRegistrySubscriberProtocol = {
rootViewRef: AppContainerRootViewRef,
packages/react-native/Libraries/ReactNative/AppContainer-dev.js
Vendored
+2 -2
View File
@@ -27,8 +27,8 @@ import * as React from 'react';
const {useEffect, useState, useCallback} = React;
const reactDevToolsHook: ReactDevToolsGlobalHook =
window.__REACT_DEVTOOLS_GLOBAL_HOOK__;
const reactDevToolsHook: ReactDevToolsGlobalHook = (window: $FlowFixMe)
.__REACT_DEVTOOLS_GLOBAL_HOOK__;
// Required for React DevTools to view / edit React Native styles in Flipper.
// Flipper doesn't inject these values when initializing DevTools.
packages/react-native/interface.js
Vendored
-4
View File
@@ -19,7 +19,3 @@
/* eslint-disable no-unused-vars */
declare var __DEV__: boolean;
declare var __REACT_DEVTOOLS_GLOBAL_HOOK__: any; /*?{
inject: ?((stuff: Object) => void)
};*/
packages/react-native/src/private/inspector/getInspectorDataForViewAtPoint.js
Vendored
+2 -2
View File
@@ -26,14 +26,14 @@ export type ReactRenderer = {
};
type AttachedRendererEventPayload = {id: number, renderer: ReactRenderer};
const reactDevToolsHook = window.__REACT_DEVTOOLS_GLOBAL_HOOK__;
const reactDevToolsHook = (window: any).__REACT_DEVTOOLS_GLOBAL_HOOK__;
invariant(
Boolean(reactDevToolsHook),
'getInspectorDataForViewAtPoint should not be used if React DevTools hook is not injected',
);
const renderers: Array<ReactRenderer> = Array.from(
window.__REACT_DEVTOOLS_GLOBAL_HOOK__.renderers.values(),
(window: any).__REACT_DEVTOOLS_GLOBAL_HOOK__.renderers.values(),
);
const appendRenderer = ({renderer}: AttachedRendererEventPayload) =>