Attempt to reduce flakyness on Modal-itest "MessageQueue is not empty" failure (#55486)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/55486

The Modal integration test `<Modal> › ref › instance › uses the "RN:ModalHostView" tag name` was flaky on CI, intermittently failing with "MessageQueue is not empty" during the global afterEach `validateEmptyMessageQueue` hook.

The root cause is that when Modal renders in __DEV__ mode, AppContainer's `useEffect` schedules passive effects as a deferred task on the RuntimeScheduler. Due to how microtask scheduling interacts with the RuntimeScheduler drain loop in Hermes, `flushMessageQueue()` inside `runTask` occasionally returns before this task is fully processed, leaving it on the queue for `validateEmptyMessageQueue` to find.

The fix adds an `afterEach` hook at the top-level `describe('<Modal>')` block that calls `Fantom.runWorkLoop()`. This provides a second drain pass before the global `validateEmptyMessageQueue` check runs (inner afterEach hooks execute before outer ones). The call is a no-op when the queue is already empty, so it adds no overhead to tests where the initial drain was complete.

This is consistent with patterns in Fantom-itest.js where Modal tests that call additional `runWorkLoop()` (for `enqueueModalSizeUpdate`) never exhibit this flakiness, precisely because that second drain catches any residual passive effects work.

Changelog:
[Internal] [Changed] -

Reviewed By: rubennorte

Differential Revision: D92828076

fbshipit-source-id: 529abe962044e2da6bee3b1e2ef4b129392fae06
This commit is contained in:
Nicola Corti authored and meta-codesync[bot] committed 2026-02-11 06:45:00 -08:00
1 parent 4356259c79
commit 233ee9d44d
1 file changed
+8
@@ -28,6 +28,14 @@ const DEFAULT_MODAL_CHILD_VIEW = (
);
describe('<Modal>', () => {
afterEach(() => {
// Flush any remaining tasks that may have been scheduled during the
// render (e.g. passive effects from AppContainer in __DEV__ mode).
// This prevents flaky "MessageQueue is not empty" failures from the
// global afterEach validation hook.
Fantom.runWorkLoop();
});
describe('props', () => {
it('renders a Modal with the default values when no props are passed', () => {
const root = Fantom.createRoot();