mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
fix TouchableWithoutFeedback and TouchableOpacity dropping onPress in React 18 (#42121)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/42121 ## Changelog: [General][Fixed] - TouchableWithoutFeedback and TouchableOpacity dropping touches with React 18. TouchableWithoutFeedback and TouchableOpacity do not trigger onPress when used with React 18. This is because it resets its pressability configuration in `componentWillUnmount`. This is fine, we want to stop deliver events and restart all timers when component is unmounted. ``` componentWillUnmount(): void { this.state.pressability.reset(); } ``` But TouchableWithoutFeedback and TouchableOpacity were not restarting the pressability configuration when component was mounted again. It was restarting the configuration in `componentDidUpdate`, which is not called when component is unmounted and mounted again. Reviewed By: fkgozali Differential Revision: D52388699 fbshipit-source-id: ef13194c6581c5d31d0f1cb465bfd0cf98d672ea
This commit is contained in:
committed by
Blake Friedman
parent
62e1c5c195
commit
220d8a51cc
@@ -314,6 +314,10 @@ class TouchableOpacity extends React.Component<Props, State> {
|
||||
}
|
||||
}
|
||||
|
||||
componentDidMount(): void {
|
||||
this.state.pressability.configure(this._createPressabilityConfig());
|
||||
}
|
||||
|
||||
componentWillUnmount(): void {
|
||||
this.state.pressability.reset();
|
||||
}
|
||||
|
||||
+4
@@ -189,6 +189,10 @@ class TouchableWithoutFeedback extends React.Component<Props, State> {
|
||||
this.state.pressability.configure(createPressabilityConfig(this.props));
|
||||
}
|
||||
|
||||
componentDidMount(): mixed {
|
||||
this.state.pressability.configure(createPressabilityConfig(this.props));
|
||||
}
|
||||
|
||||
componentWillUnmount(): void {
|
||||
this.state.pressability.reset();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user