Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename minDuration as minTestExecutionTime for clarity (#53321)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/53321

Changelog: [internal]

Just a rename to make it easier to understand.

Reviewed By: rshest

Differential Revision: D80404378

fbshipit-source-id: 3d7e89797be3b92599e07b4b64d2a720756a4f3b
This commit is contained in:
Rubén Norte
2025-08-18 08:57:52 -07:00
committed by Facebook GitHub Bot
parent 6c37b5b682
commit 219fc99e99
3 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/src/private/webapis/performance/__tests__/Performance-benchmark-itest.js
Vendored
+1 -1
View File
@@ -22,7 +22,7 @@ const clearMarksAndMeasures = () => {
};
Fantom.unstable_benchmark
.suite('Performance API', {minIterations: 50000, minDuration: 0})
.suite('Performance API', {minIterations: 50000})
.test(
'mark (default)',
() => {
private/react-native-fantom/src/Benchmark.js
Vendored
+6 -6
View File
@@ -24,9 +24,9 @@ type SyncFn = () => FnReturnedObject | void;
export type SuiteOptions = $ReadOnly<{
minIterations?: number,
minDuration?: number,
minTestExecutionTimeMs?: number,
warmup?: boolean,
minWarmupDuration?: number,
minWarmupDurationMs?: number,
minWarmupIterations?: number,
disableOptimizedBuildCheck?: boolean,
testOnly?: boolean,
@@ -141,16 +141,16 @@ export function suite(
benchOptions.iterations = suiteOptions.minIterations;
}
if (suiteOptions.minDuration != null) {
benchOptions.time = suiteOptions.minDuration;
if (suiteOptions.minTestExecutionTimeMs != null) {
benchOptions.time = suiteOptions.minTestExecutionTimeMs;
}
if (suiteOptions.warmup != null) {
benchOptions.warmup = suiteOptions.warmup;
}
if (suiteOptions.minWarmupDuration != null) {
benchOptions.warmupTime = suiteOptions.minWarmupDuration;
if (suiteOptions.minWarmupDurationMs != null) {
benchOptions.warmupTime = suiteOptions.minWarmupDurationMs;
}
if (suiteOptions.minWarmupIterations != null) {
private/react-native-fantom/src/__tests__/benchmarks/BenchmarkTests-testMode-benchmark-itest.js
Vendored
+2 -2
View File
@@ -27,8 +27,8 @@ Fantom.unstable_benchmark
warmup: true,
minWarmupIterations: 10,
minIterations: 10,
minDuration: 1000,
minWarmupDuration: 1000,
minTestExecutionTimeMs: 1000,
minWarmupDurationMs: 1000,
})
.test('test', () => {
runs++;