Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Proper implementation -[RCTParagraphComponentView prepareForRecycle]`

Browse Source 
Summary: Over-retaining a LocalData object inside the View can cause a crash during tearing down JS VM because LocalData can indirectly retain EventEmitter objects which were not properly "disabled".

Reviewed By: sahrens

Differential Revision: D13196887

fbshipit-source-id: 001d9fadf775c89f750c84fe8da9b84d4636631c
This commit is contained in:
Valentin Shergin
2018-11-26 13:51:19 -08:00
committed by Facebook Github Bot
parent ffd2409172
commit 215a0f0f21
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/Fabric/Mounting/ComponentViews/Text/RCTParagraphComponentView.mm
+6
View File
@@ -63,6 +63,12 @@ using namespace facebook::react;
[self setNeedsDisplay];
}
- (void)prepareForRecycle
{
[super prepareForRecycle];
_paragraphLocalData.reset();
}
- (void)drawRect:(CGRect)rect
{
if (!_paragraphLocalData) {