Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Removing SharedYogaStylableProps and small codestyle changes

Browse Source 
Summary: Trivial. We don't use it.

Reviewed By: sammy-SC

Differential Revision: D16139556

fbshipit-source-id: bac282c1aa228c10d27ebd636cf71fcc33b322e9
This commit is contained in:
Valentin Shergin
2019-07-08 21:10:47 -07:00
committed by Facebook Github Bot
parent 424f93022d
commit 2111f205ae
2 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/fabric/components/view/yoga/YogaStylableProps.cpp
+4 -4
View File
@@ -19,19 +19,19 @@
namespace facebook {
namespace react {
YogaStylableProps::YogaStylableProps(const YGStyle &yogaStyle)
YogaStylableProps::YogaStylableProps(YGStyle const &yogaStyle)
: yogaStyle(yogaStyle) {}
YogaStylableProps::YogaStylableProps(
const YogaStylableProps &sourceProps,
const RawProps &rawProps)
YogaStylableProps const &sourceProps,
RawProps const &rawProps)
: yogaStyle(convertRawProp(rawProps, sourceProps.yogaStyle)){};
#pragma mark - DebugStringConvertible
#if RN_DEBUG_STRING_CONVERTIBLE
SharedDebugStringConvertibleList YogaStylableProps::getDebugProps() const {
const auto defaultYogaStyle = YGStyle{};
auto const defaultYogaStyle = YGStyle{};
return {
debugStringConvertibleItem(
"direction", yogaStyle.direction(), defaultYogaStyle.direction()),
ReactCommon/fabric/components/view/yoga/YogaStylableProps.h
+4 -8
View File
@@ -15,23 +15,19 @@
namespace facebook {
namespace react {
class YogaStylableProps;
typedef std::shared_ptr<const YogaStylableProps> SharedYogaStylableProps;
class YogaStylableProps {
public:
YogaStylableProps() = default;
YogaStylableProps(const YGStyle &yogaStyle);
YogaStylableProps(YGStyle const &yogaStyle);
YogaStylableProps(
const YogaStylableProps &sourceProps,
const RawProps &rawProps);
YogaStylableProps const &sourceProps,
RawProps const &rawProps);
#pragma mark - Props
protected:
friend class YogaLayoutableShadowNode;
const YGStyle yogaStyle{};
YGStyle const yogaStyle{};
#if RN_DEBUG_STRING_CONVERTIBLE