Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply Nullsafe FIXMEs for xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/turbomodule/core/TurboModuleInteropUtils.java (#50367)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/50367

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D71979600

fbshipit-source-id: be36f4c409a0423b3d3ccdf2c28d96c7a3f50201
This commit is contained in:
Gijs Weterings
2025-04-07 06:33:09 -07:00
committed by Facebook GitHub Bot
parent e6fc1ecb6f
commit 207fc3f5d3
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/turbomodule/core/TurboModuleInteropUtils.java
+5
View File
@@ -94,7 +94,9 @@ class TurboModuleInteropUtils {
if (returnType != Map.class) {
// TODO(T145105887) Output error. getConstants must always have a return type of Map
}
// NULLSAFE_FIXME[Nullable Dereference]
} else if (annotation.isBlockingSynchronousMethod() && returnType == void.class
// NULLSAFE_FIXME[Nullable Dereference]
|| !annotation.isBlockingSynchronousMethod() && returnType != void.class) {
// TODO(T145105887): Output error. TurboModule system assumes returnType == void iff the
// method is synchronous.
@@ -115,12 +117,14 @@ class TurboModuleInteropUtils {
Class<? extends NativeModule> classForMethods = module.getClass();
Class<? extends NativeModule> superClass =
(Class<? extends NativeModule>) classForMethods.getSuperclass();
// NULLSAFE_FIXME[Parameter Not Nullable]
if (TurboModule.class.isAssignableFrom(superClass)) {
// For java module that is based on generated flow-type spec, inspect the
// spec abstract class instead, which is the super class of the given java
// module.
classForMethods = superClass;
}
// NULLSAFE_FIXME[Nullable Dereference]
return classForMethods.getDeclaredMethods();
}
@@ -214,6 +218,7 @@ class TurboModuleInteropUtils {
}
private static String convertClassToJniType(Class<?> cls) {
// NULLSAFE_FIXME[Nullable Dereference]
return 'L' + cls.getCanonicalName().replace('.', '/') + ';';
}