Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make Java only NativeModules TurboModule-compatible

Browse Source 
Summary:
For NativeModules that don't need to be accessed from JS, we can just have them implement the TurboModule interface. This is enough to make them be instantiated via the TurboModule system.

Changelog:
[Android][Added] - Make Java only NativeModules TurboModule-compatible

Reviewed By: ejanzer

Differential Revision: D18787789

fbshipit-source-id: d513006ffd736621adbd41146ed6280a60a7437e
This commit is contained in:
Ramanpreet Nara
2019-12-13 17:47:46 -08:00
committed by Facebook Github Bot
parent 399cabd1bb
commit 1d3a95d96c
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/modules/fresco/BUCK
+1
View File
@@ -32,5 +32,6 @@ rn_android_library(
react_native_target("java/com/facebook/react/module/annotations:annotations"),
react_native_target("java/com/facebook/react/modules/common:common"),
react_native_target("java/com/facebook/react/modules/network:network"),
react_native_target("java/com/facebook/react/turbomodule/core/interfaces:interfaces"),
],
)
ReactAndroid/src/main/java/com/facebook/react/modules/fresco/FrescoModule.java
+2 -1
View File
@@ -24,6 +24,7 @@ import com.facebook.react.modules.common.ModuleDataCleaner;
import com.facebook.react.modules.network.CookieJarContainer;
import com.facebook.react.modules.network.ForwardingCookieHandler;
import com.facebook.react.modules.network.OkHttpClientProvider;
import com.facebook.react.turbomodule.core.interfaces.TurboModule;
import java.util.HashSet;
import okhttp3.JavaNetCookieJar;
import okhttp3.OkHttpClient;
@@ -35,7 +36,7 @@ import okhttp3.OkHttpClient;
*/
@ReactModule(name = FrescoModule.NAME, needsEagerInit = true)
public class FrescoModule extends ReactContextBaseJavaModule
implements ModuleDataCleaner.Cleanable, LifecycleEventListener {
implements ModuleDataCleaner.Cleanable, LifecycleEventListener, TurboModule {
public static final String NAME = "FrescoModule";
private final boolean mClearOnDestroy;