From 1d3a95d96c7fd0ce65727a397ca6f6bdcc804e9a Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Fri, 13 Dec 2019 17:47:46 -0800 Subject: [PATCH] Make Java only NativeModules TurboModule-compatible Summary: For NativeModules that don't need to be accessed from JS, we can just have them implement the TurboModule interface. This is enough to make them be instantiated via the TurboModule system. Changelog: [Android][Added] - Make Java only NativeModules TurboModule-compatible Reviewed By: ejanzer Differential Revision: D18787789 fbshipit-source-id: d513006ffd736621adbd41146ed6280a60a7437e --- .../src/main/java/com/facebook/react/modules/fresco/BUCK | 1 + .../java/com/facebook/react/modules/fresco/FrescoModule.java | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/BUCK index 0cad1b2e00a..c7b6ce5f7ae 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/BUCK @@ -32,5 +32,6 @@ rn_android_library( react_native_target("java/com/facebook/react/module/annotations:annotations"), react_native_target("java/com/facebook/react/modules/common:common"), react_native_target("java/com/facebook/react/modules/network:network"), + react_native_target("java/com/facebook/react/turbomodule/core/interfaces:interfaces"), ], ) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/FrescoModule.java b/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/FrescoModule.java index 0b5c3e32dae..df26770d309 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/FrescoModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/FrescoModule.java @@ -24,6 +24,7 @@ import com.facebook.react.modules.common.ModuleDataCleaner; import com.facebook.react.modules.network.CookieJarContainer; import com.facebook.react.modules.network.ForwardingCookieHandler; import com.facebook.react.modules.network.OkHttpClientProvider; +import com.facebook.react.turbomodule.core.interfaces.TurboModule; import java.util.HashSet; import okhttp3.JavaNetCookieJar; import okhttp3.OkHttpClient; @@ -35,7 +36,7 @@ import okhttp3.OkHttpClient; */ @ReactModule(name = FrescoModule.NAME, needsEagerInit = true) public class FrescoModule extends ReactContextBaseJavaModule - implements ModuleDataCleaner.Cleanable, LifecycleEventListener { + implements ModuleDataCleaner.Cleanable, LifecycleEventListener, TurboModule { public static final String NAME = "FrescoModule"; private final boolean mClearOnDestroy;