Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Run JSI tests in Hermes CMake build (#38659)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38659

Run JSI tests against all the Hermes implementations exposed by
`APITestFactory`. To build with the older version of gtest available in
Hermes, the test needed to be slightly modified.

Changelog: [Internal]

Reviewed By: avp

Differential Revision: D47373805

fbshipit-source-id: 58958b4a60dac25f1b7defa490b888f21a665b0c
This commit is contained in:
Neil Dhar
2023-08-01 16:12:50 -07:00
committed by Facebook GitHub Bot
parent b65dbf68d0
commit 1b1097de1d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactCommon/jsi/jsi/test/testlib.cpp
+3 -3
View File
@@ -754,7 +754,7 @@ TEST_P(JSITest, HostFunctionTest) {
.utf8(rt),
"A cat was called with std::function::target");
EXPECT_TRUE(callable.isHostFunction(rt));
EXPECT_NE(callable.getHostFunction(rt).target<Callable>(), nullptr);
EXPECT_TRUE(callable.getHostFunction(rt).target<Callable>() != nullptr);
std::string strval = "strval1";
auto getter = Object(rt);
@@ -1245,7 +1245,7 @@ TEST_P(JSITest, MultiDecoratorTest) {
0,
[](Runtime& rt, const Value& thisVal, const Value* args, size_t count) {
MultiRuntime* funcmrt = dynamic_cast<MultiRuntime*>(&rt);
EXPECT_NE(funcmrt, nullptr);
EXPECT_TRUE(funcmrt != nullptr);
EXPECT_EQ(funcmrt->count(), 3);
EXPECT_EQ(funcmrt->nest(), 1);
return Value::undefined();
@@ -1439,7 +1439,7 @@ TEST_P(JSITest, MultilevelDecoratedHostObject) {
EXPECT_EQ(1, RD2::numGets);
}
INSTANTIATE_TEST_SUITE_P(
INSTANTIATE_TEST_CASE_P(
Runtimes,
JSITest,
::testing::ValuesIn(runtimeGenerators()));