Executors.java->.kt (#45702)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/45702

# Changelog:
[Internal] -

As in the title.

Reviewed By: tdn120

Differential Revision: D60282843

fbshipit-source-id: b43262d62d35d9cf172b90ab0c95d100dea43e26
This commit is contained in:
Ruslan Shestopalyuk
2024-07-27 12:34:34 -07:00
committed by Facebook GitHub Bot
parent bf0705a308
commit 1a4075f72f
2 changed files with 44 additions and 53 deletions
@@ -1,53 +0,0 @@
/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
package com.facebook.react.runtime.internal.bolts;
import com.facebook.infer.annotation.Nullsafe;
import com.facebook.react.bridge.UiThreadUtil;
import java.util.concurrent.Executor;
/**
* This was created because the helper methods in {@link java.util.concurrent.Executors} do not work
* as people would normally expect.
*
* <p>Normally, you would think that a cached thread pool would create new threads when necessary,
* queue them when the pool is full, and kill threads when they've been inactive for a certain
* period of time. This is not how {@link java.util.concurrent.Executors#newCachedThreadPool()}
* works.
*
* <p>Instead, {@link java.util.concurrent.Executors#newCachedThreadPool()} executes all tasks on a
* new or cached thread immediately because corePoolSize is 0, SynchronousQueue is a queue with size
* 0 and maxPoolSize is Integer.MAX_VALUE. This is dangerous because it can create an unchecked
* amount of threads.
*/
@Nullsafe(Nullsafe.Mode.LOCAL)
/* package */
final class Executors {
public static final Executor UI_THREAD = new UIThreadExecutor();
public static final Executor IMMEDIATE = new ImmediateExecutor();
private static class UIThreadExecutor implements Executor {
@Override
public void execute(Runnable command) {
// Otherwise, post it on the main thread handler
UiThreadUtil.runOnUiThread(command);
}
}
/**
* An {@link java.util.concurrent.Executor} that schedules tasks to run asynchronously on the UI
* thread.
*/
private static class ImmediateExecutor implements Executor {
@Override
public void execute(Runnable command) {
command.run();
}
}
}
@@ -0,0 +1,44 @@
/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
package com.facebook.react.runtime.internal.bolts
import com.facebook.react.bridge.UiThreadUtil
import java.util.concurrent.Executor
/**
* This was created because the helper methods in [java.util.concurrent.Executors] do not work as
* people would normally expect.
*
* Normally, you would think that a cached thread pool would create new threads when necessary,
* queue them when the pool is full, and kill threads when they've been inactive for a certain
* period of time. This is not how [java.util.concurrent.Executors.newCachedThreadPool] works.
*
* Instead, [java.util.concurrent.Executors.newCachedThreadPool] executes all tasks on a new or
* cached thread immediately because corePoolSize is 0, SynchronousQueue is a queue with size 0 and
* maxPoolSize is Integer.MAX_VALUE. This is dangerous because it can create an unchecked amount of
* threads.
*/
internal object Executors {
@JvmField public val UI_THREAD: Executor = UIThreadExecutor()
@JvmField public val IMMEDIATE: Executor = ImmediateExecutor()
private class UIThreadExecutor : Executor {
override fun execute(command: Runnable) {
UiThreadUtil.runOnUiThread(command)
}
}
/**
* An [java.util.concurrent.Executor] that schedules tasks to run asynchronously on the UI thread.
*/
private class ImmediateExecutor : Executor {
override fun execute(command: Runnable) {
command.run()
}
}
}