mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Fix unused parameter warnings in ShadowNode.h (#56519)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56519 Fixed clang-diagnostic-unused-parameter warnings in ShadowNode.h by commenting out unused parameter names in the completeClone method. This addresses warnings for parameters `sourceShadowNode` and `fragment` that were declared but not used in the function body. Also applied lint patch to remove redundant `virtual` keyword from the destructor declaration. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D101108467 fbshipit-source-id: 3c717f27df362e68f308b0e0f119b0fe43e82818
This commit is contained in:
1 parent
d65511474f
commit
19a23e7914
7 files changed
+18
-18
No files matched your search
@@ -4614,14 +4614,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
|
||||
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
|
||||
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
|
||||
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
|
||||
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
|
||||
public virtual ~ShadowNode() override = default;
|
||||
public void sealRecursive() const;
|
||||
public void setMounted(bool mounted) const;
|
||||
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
|
||||
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
|
||||
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
|
||||
public ~ShadowNode() override = default;
|
||||
}
|
||||
|
||||
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
@@ -5478,7 +5478,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
|
||||
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
|
||||
public virtual bool getIsLayoutClean() const override;
|
||||
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
|
||||
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
|
||||
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
|
||||
public virtual void dirtyLayout() override;
|
||||
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
|
||||
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;
|
||||
|
||||
@@ -4605,14 +4605,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
|
||||
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
|
||||
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
|
||||
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
|
||||
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
|
||||
public virtual ~ShadowNode() override = default;
|
||||
public void sealRecursive() const;
|
||||
public void setMounted(bool mounted) const;
|
||||
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
|
||||
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
|
||||
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
|
||||
public ~ShadowNode() override = default;
|
||||
}
|
||||
|
||||
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
@@ -5469,7 +5469,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
|
||||
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
|
||||
public virtual bool getIsLayoutClean() const override;
|
||||
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
|
||||
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
|
||||
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
|
||||
public virtual void dirtyLayout() override;
|
||||
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
|
||||
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;
|
||||
|
||||
@@ -7198,14 +7198,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
|
||||
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
|
||||
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
|
||||
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
|
||||
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
|
||||
public virtual ~ShadowNode() override = default;
|
||||
public void sealRecursive() const;
|
||||
public void setMounted(bool mounted) const;
|
||||
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
|
||||
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
|
||||
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
|
||||
public ~ShadowNode() override = default;
|
||||
}
|
||||
|
||||
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
|
||||
@@ -7189,14 +7189,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
|
||||
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
|
||||
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
|
||||
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
|
||||
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
|
||||
public virtual ~ShadowNode() override = default;
|
||||
public void sealRecursive() const;
|
||||
public void setMounted(bool mounted) const;
|
||||
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
|
||||
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
|
||||
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
|
||||
public ~ShadowNode() override = default;
|
||||
}
|
||||
|
||||
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
|
||||
@@ -3174,14 +3174,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
|
||||
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
|
||||
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
|
||||
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
|
||||
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
|
||||
public virtual ~ShadowNode() override = default;
|
||||
public void sealRecursive() const;
|
||||
public void setMounted(bool mounted) const;
|
||||
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
|
||||
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
|
||||
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
|
||||
public ~ShadowNode() override = default;
|
||||
}
|
||||
|
||||
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
@@ -3893,7 +3893,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
|
||||
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
|
||||
public virtual bool getIsLayoutClean() const override;
|
||||
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
|
||||
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
|
||||
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
|
||||
public virtual void dirtyLayout() override;
|
||||
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
|
||||
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;
|
||||
|
||||
@@ -3165,14 +3165,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
|
||||
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
|
||||
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
|
||||
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
|
||||
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
|
||||
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
|
||||
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
|
||||
public virtual ~ShadowNode() override = default;
|
||||
public void sealRecursive() const;
|
||||
public void setMounted(bool mounted) const;
|
||||
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
|
||||
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
|
||||
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
|
||||
public ~ShadowNode() override = default;
|
||||
}
|
||||
|
||||
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
|
||||
@@ -3884,7 +3884,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
|
||||
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
|
||||
public virtual bool getIsLayoutClean() const override;
|
||||
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
|
||||
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
|
||||
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
|
||||
public virtual void dirtyLayout() override;
|
||||
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
|
||||
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;
|
||||
|
||||
Reference in new issue
Block a user