From 19a23e7914fe6dded4e183efd789c1baa0118824 Mon Sep 17 00:00:00 2001 From: Christoph Purrer Date: Tue, 21 Apr 2026 18:42:17 -0700 Subject: [PATCH] Fix unused parameter warnings in ShadowNode.h (#56519) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56519 Fixed clang-diagnostic-unused-parameter warnings in ShadowNode.h by commenting out unused parameter names in the completeClone method. This addresses warnings for parameters `sourceShadowNode` and `fragment` that were declared but not used in the function body. Also applied lint patch to remove redundant `virtual` keyword from the destructor declaration. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D101108467 fbshipit-source-id: 3c717f27df362e68f308b0e0f119b0fe43e82818 --- .../ReactCommon/react/renderer/core/ShadowNode.h | 4 ++-- scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api | 6 +++--- scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api | 6 +++--- scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api | 4 ++-- scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api | 4 ++-- scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api | 6 +++--- scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api | 6 +++--- 7 files changed, 18 insertions(+), 18 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h b/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h index 4a804c63dfb..1b3a6d8404a 100644 --- a/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h +++ b/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h @@ -83,7 +83,7 @@ class ShadowNode : public Sealable, public DebugStringConvertible, public jsi::N ShadowNode(const ShadowNode &shadowNode) noexcept = delete; ShadowNode &operator=(const ShadowNode &other) noexcept = delete; - virtual ~ShadowNode() override = default; + ~ShadowNode() override = default; /* * Clones the shadow node using the ShadowNode's ComponentDescriptor. @@ -118,7 +118,7 @@ class ShadowNode : public Sealable, public DebugStringConvertible, public jsi::N * Called, once a fully derived ShadowNode clone has been created via * ComponentDescriptor::cloneShadowNode. */ - virtual void completeClone(const ShadowNode &sourceShadowNode, const ShadowNodeFragment &fragment) {} + virtual void completeClone(const ShadowNode & /* sourceShadowNode */, const ShadowNodeFragment & /* fragment */) {} #pragma mark - Getters diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api index c21d8cb3f95..68e84ac76f4 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api @@ -4614,14 +4614,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; public virtual void appendChild(const std::shared_ptr& child); - public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); + public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); - public virtual ~ShadowNode() override = default; public void sealRecursive() const; public void setMounted(bool mounted) const; public void setRuntimeShadowNodeReference(const std::shared_ptr& runtimeShadowNodeReference) const; public void transferRuntimeShadowNodeReference(const std::shared_ptr& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const; public void updateRuntimeShadowNodeReference(const std::shared_ptr& destinationShadowNode) const; + public ~ShadowNode() override = default; } class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState { @@ -5478,7 +5478,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout public using Shared = std::shared_ptr; public virtual bool getIsLayoutClean() const override; public virtual void appendChild(const std::shared_ptr& child) override; - public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override; + public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override; public virtual void dirtyLayout() override; public virtual void layout(facebook::react::LayoutContext layoutContext) override; public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override; diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api index c68c15ab574..288d63fc812 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api @@ -4605,14 +4605,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; public virtual void appendChild(const std::shared_ptr& child); - public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); + public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); - public virtual ~ShadowNode() override = default; public void sealRecursive() const; public void setMounted(bool mounted) const; public void setRuntimeShadowNodeReference(const std::shared_ptr& runtimeShadowNodeReference) const; public void transferRuntimeShadowNodeReference(const std::shared_ptr& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const; public void updateRuntimeShadowNodeReference(const std::shared_ptr& destinationShadowNode) const; + public ~ShadowNode() override = default; } class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState { @@ -5469,7 +5469,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout public using Shared = std::shared_ptr; public virtual bool getIsLayoutClean() const override; public virtual void appendChild(const std::shared_ptr& child) override; - public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override; + public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override; public virtual void dirtyLayout() override; public virtual void layout(facebook::react::LayoutContext layoutContext) override; public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override; diff --git a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api index 1d91854607b..afbf6cd8c3e 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api @@ -7198,14 +7198,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; public virtual void appendChild(const std::shared_ptr& child); - public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); + public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); - public virtual ~ShadowNode() override = default; public void sealRecursive() const; public void setMounted(bool mounted) const; public void setRuntimeShadowNodeReference(const std::shared_ptr& runtimeShadowNodeReference) const; public void transferRuntimeShadowNodeReference(const std::shared_ptr& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const; public void updateRuntimeShadowNodeReference(const std::shared_ptr& destinationShadowNode) const; + public ~ShadowNode() override = default; } class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState { diff --git a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api index 998724f15d4..361887066fa 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api @@ -7189,14 +7189,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; public virtual void appendChild(const std::shared_ptr& child); - public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); + public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); - public virtual ~ShadowNode() override = default; public void sealRecursive() const; public void setMounted(bool mounted) const; public void setRuntimeShadowNodeReference(const std::shared_ptr& runtimeShadowNodeReference) const; public void transferRuntimeShadowNodeReference(const std::shared_ptr& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const; public void updateRuntimeShadowNodeReference(const std::shared_ptr& destinationShadowNode) const; + public ~ShadowNode() override = default; } class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState { diff --git a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api index 69deab999b9..1ab04008f79 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api @@ -3174,14 +3174,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; public virtual void appendChild(const std::shared_ptr& child); - public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); + public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); - public virtual ~ShadowNode() override = default; public void sealRecursive() const; public void setMounted(bool mounted) const; public void setRuntimeShadowNodeReference(const std::shared_ptr& runtimeShadowNodeReference) const; public void transferRuntimeShadowNodeReference(const std::shared_ptr& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const; public void updateRuntimeShadowNodeReference(const std::shared_ptr& destinationShadowNode) const; + public ~ShadowNode() override = default; } class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState { @@ -3893,7 +3893,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout public using Shared = std::shared_ptr; public virtual bool getIsLayoutClean() const override; public virtual void appendChild(const std::shared_ptr& child) override; - public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override; + public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override; public virtual void dirtyLayout() override; public virtual void layout(facebook::react::LayoutContext layoutContext) override; public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override; diff --git a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api index b9921b567fe..cc2d0a81ef4 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api @@ -3165,14 +3165,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; public virtual void appendChild(const std::shared_ptr& child); - public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); + public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); - public virtual ~ShadowNode() override = default; public void sealRecursive() const; public void setMounted(bool mounted) const; public void setRuntimeShadowNodeReference(const std::shared_ptr& runtimeShadowNodeReference) const; public void transferRuntimeShadowNodeReference(const std::shared_ptr& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const; public void updateRuntimeShadowNodeReference(const std::shared_ptr& destinationShadowNode) const; + public ~ShadowNode() override = default; } class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState { @@ -3884,7 +3884,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout public using Shared = std::shared_ptr; public virtual bool getIsLayoutClean() const override; public virtual void appendChild(const std::shared_ptr& child) override; - public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override; + public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override; public virtual void dirtyLayout() override; public virtual void layout(facebook::react::LayoutContext layoutContext) override; public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;