Fling: Cleanup enableVirtualViewRenderState (#55095)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/55095

Deletes the `enableVirtualViewRenderState` feature flag and applies the new behavior everywhere.

Changelog:
[Internal]

Reviewed By: lunaleaps

Differential Revision: D90334878

fbshipit-source-id: 54213bdb8c616d85d069cf001e6a025478665225
This commit is contained in:
Tim Yung authored and meta-codesync[bot] committed 2026-01-08 15:00:26 -08:00
1 parent d339c6a2c9
commit 198c1a7880
23 files changed
+82 -216

No files matched your search

@@ -70,19 +70,16 @@ using namespace facebook::react;
}
}
// If disabled, `_renderState` will always be `RCTVirtualViewRenderStateUnknown`.
if (ReactNativeFeatureFlags::enableVirtualViewRenderState()) {
switch (newViewProps.renderState) {
case 1:
_renderState = RCTVirtualViewRenderStateRendered;
break;
case 2:
_renderState = RCTVirtualViewRenderStateNone;
break;
default:
_renderState = RCTVirtualViewRenderStateUnknown;
break;
}
switch (newViewProps.renderState) {
case 1:
_renderState = RCTVirtualViewRenderStateRendered;
break;
case 2:
_renderState = RCTVirtualViewRenderStateNone;
break;
default:
_renderState = RCTVirtualViewRenderStateUnknown;
break;
}
const auto &newBaseViewProps = static_cast<const ViewProps &>(*props);
@@ -196,17 +193,13 @@ static BOOL sIsAccessibilityUsed = NO;
switch (newMode) {
case RCTVirtualViewModeVisible:
if (_renderState == RCTVirtualViewRenderStateUnknown) {
// Feature flag is disabled, so use the former logic.
// If the previous mode was hidden, emit a mode change even if `renderState` is rendered,
// because the hidden mode change is still pending and will eventually be committed. Only
// skip emitting a mode change if the previous mode was prerender and the result of that
// event has already been committed.
if (!oldMode.has_value() || oldMode == RCTVirtualViewModeHidden ||
_renderState != RCTVirtualViewRenderStateRendered) {
[self _dispatchSyncModeChange:event];
} else {
// If the previous mode was prerender and the result of dispatching that event was committed, we do not need
// to dispatch an event for visible.
const auto wasPrerenderCommitted = oldMode.has_value() && oldMode == RCTVirtualViewModePrerender &&
_renderState == RCTVirtualViewRenderStateRendered;
if (!wasPrerenderCommitted) {
[self _dispatchSyncModeChange:event];
}
}
break;
case RCTVirtualViewModePrerender:
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<91ad23aa529522a802b8d03198d7ccb9>>
* @generated SignedSource<<e12e5425f1a51acfd0f244e5d4f46a3e>>
*/
/**
@@ -342,12 +342,6 @@ public object ReactNativeFeatureFlags {
@JvmStatic
public fun enableVirtualViewDebugFeatures(): Boolean = accessor.enableVirtualViewDebugFeatures()
/**
* Enables reading render state when dispatching VirtualView events.
*/
@JvmStatic
public fun enableVirtualViewRenderState(): Boolean = accessor.enableVirtualViewRenderState()
/**
* Uses the default event priority instead of the discreet event priority by default when dispatching events from Fabric to React.
*/
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<6188f6b73c835b514bd13de3b7a3f55c>>
* @generated SignedSource<<fe103b59da0f78a6e834ca92603531fb>>
*/
/**
@@ -72,7 +72,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
private var enableViewRecyclingForViewCache: Boolean? = null
private var enableVirtualViewContainerStateExperimentalCache: Boolean? = null
private var enableVirtualViewDebugFeaturesCache: Boolean? = null
private var enableVirtualViewRenderStateCache: Boolean? = null
private var fixMappingOfEventPrioritiesBetweenFabricAndReactCache: Boolean? = null
private var fixTextClippingAndroid15useBoundsForWidthCache: Boolean? = null
private var fuseboxAssertSingleHostStateCache: Boolean? = null
@@ -573,15 +572,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
return cached
}
override fun enableVirtualViewRenderState(): Boolean {
var cached = enableVirtualViewRenderStateCache
if (cached == null) {
cached = ReactNativeFeatureFlagsCxxInterop.enableVirtualViewRenderState()
enableVirtualViewRenderStateCache = cached
}
return cached
}
override fun fixMappingOfEventPrioritiesBetweenFabricAndReact(): Boolean {
var cached = fixMappingOfEventPrioritiesBetweenFabricAndReactCache
if (cached == null) {
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<2528d994ff2ed6ada21f7ff67cdfcd0a>>
* @generated SignedSource<<0ae5a806950b4bfaaaccde774114ab4e>>
*/
/**
@@ -132,8 +132,6 @@ public object ReactNativeFeatureFlagsCxxInterop {
@DoNotStrip @JvmStatic public external fun enableVirtualViewDebugFeatures(): Boolean
@DoNotStrip @JvmStatic public external fun enableVirtualViewRenderState(): Boolean
@DoNotStrip @JvmStatic public external fun fixMappingOfEventPrioritiesBetweenFabricAndReact(): Boolean
@DoNotStrip @JvmStatic public external fun fixTextClippingAndroid15useBoundsForWidth(): Boolean
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<c9a6da699b29672243ed2535007f3eb2>>
* @generated SignedSource<<532504ff7b4a7f4c45649fc59ecade3a>>
*/
/**
@@ -127,8 +127,6 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
override fun enableVirtualViewDebugFeatures(): Boolean = false
override fun enableVirtualViewRenderState(): Boolean = true
override fun fixMappingOfEventPrioritiesBetweenFabricAndReact(): Boolean = false
override fun fixTextClippingAndroid15useBoundsForWidth(): Boolean = false
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<f691287ee63dfd86f0a1f5a8c16cb0be>>
* @generated SignedSource<<d4caae6713b5c26f17841839903ea529>>
*/
/**
@@ -76,7 +76,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
private var enableViewRecyclingForViewCache: Boolean? = null
private var enableVirtualViewContainerStateExperimentalCache: Boolean? = null
private var enableVirtualViewDebugFeaturesCache: Boolean? = null
private var enableVirtualViewRenderStateCache: Boolean? = null
private var fixMappingOfEventPrioritiesBetweenFabricAndReactCache: Boolean? = null
private var fixTextClippingAndroid15useBoundsForWidthCache: Boolean? = null
private var fuseboxAssertSingleHostStateCache: Boolean? = null
@@ -629,16 +628,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
return cached
}
override fun enableVirtualViewRenderState(): Boolean {
var cached = enableVirtualViewRenderStateCache
if (cached == null) {
cached = currentProvider.enableVirtualViewRenderState()
accessedFeatureFlags.add("enableVirtualViewRenderState")
enableVirtualViewRenderStateCache = cached
}
return cached
}
override fun fixMappingOfEventPrioritiesBetweenFabricAndReact(): Boolean {
var cached = fixMappingOfEventPrioritiesBetweenFabricAndReactCache
if (cached == null) {
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<f229d1a748eb05b6d796275a68cd636d>>
* @generated SignedSource<<351ae3b05fae543b52eaa7bcf7f5f479>>
*/
/**
@@ -127,8 +127,6 @@ public interface ReactNativeFeatureFlagsProvider {
@DoNotStrip public fun enableVirtualViewDebugFeatures(): Boolean
@DoNotStrip public fun enableVirtualViewRenderState(): Boolean
@DoNotStrip public fun fixMappingOfEventPrioritiesBetweenFabricAndReact(): Boolean
@DoNotStrip public fun fixTextClippingAndroid15useBoundsForWidth(): Boolean
@@ -155,27 +155,21 @@ public class ReactVirtualView(context: Context) :
when (newMode) {
VirtualViewMode.Visible -> {
if (renderState == VirtualViewRenderState.Unknown) {
// Feature flag is disabled, so use the former logic.
// If the previous mode was hidden, emit a mode change even if `renderState` is rendered,
// because the hidden mode change is still pending and will eventually be committed. Only
// skip emitting a mode change if the previous mode was prerender and the result of that
// event has already been committed.
if (
oldMode == null ||
oldMode == VirtualViewMode.Hidden ||
renderState != VirtualViewRenderState.Rendered
) {
modeChangeEmitter?.emitModeChange(
VirtualViewMode.Visible,
containerRelativeRect,
thresholdRect,
synchronous = true,
)
} else {
// If the previous mode was prerender and the result of dispatching that event was
// committed, we do not need to dispatch an event for visible.
val wasPrerenderCommitted =
oldMode == VirtualViewMode.Prerender && renderState == VirtualViewRenderState.Rendered
if (!wasPrerenderCommitted) {
modeChangeEmitter?.emitModeChange(
VirtualViewMode.Visible,
containerRelativeRect,
thresholdRect,
synchronous = true,
)
}
}
}
VirtualViewMode.Prerender -> {
@@ -9,7 +9,6 @@ package com.facebook.react.views.virtual.view
import android.graphics.Rect
import androidx.annotation.VisibleForTesting
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
import com.facebook.react.module.annotations.ReactModule
import com.facebook.react.uimanager.ThemedReactContext
import com.facebook.react.uimanager.UIManagerHelper
@@ -46,15 +45,12 @@ public class ReactVirtualViewManager :
@ReactProp(name = "renderState")
override fun setRenderState(view: ReactVirtualView, value: Int) {
// If disabled, `renderState` will always be `VirtualViewRenderState.Unknown`.
if (ReactNativeFeatureFlags.enableVirtualViewRenderState()) {
view.renderState =
when (value) {
1 -> VirtualViewRenderState.Rendered
2 -> VirtualViewRenderState.None
else -> VirtualViewRenderState.Unknown
}
}
view.renderState =
when (value) {
1 -> VirtualViewRenderState.Rendered
2 -> VirtualViewRenderState.None
else -> VirtualViewRenderState.Unknown
}
}
override fun setNativeId(view: ReactVirtualView, nativeId: String?) {
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<f88a6aeb9289fd48d083cfccfc609d79>>
* @generated SignedSource<<9841e9badfe84669fde89f35467d4c13>>
*/
/**
@@ -351,12 +351,6 @@ class ReactNativeFeatureFlagsJavaProvider
return method(javaProvider_);
}
bool enableVirtualViewRenderState() override {
static const auto method =
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("enableVirtualViewRenderState");
return method(javaProvider_);
}
bool fixMappingOfEventPrioritiesBetweenFabricAndReact() override {
static const auto method =
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("fixMappingOfEventPrioritiesBetweenFabricAndReact");
@@ -807,11 +801,6 @@ bool JReactNativeFeatureFlagsCxxInterop::enableVirtualViewDebugFeatures(
return ReactNativeFeatureFlags::enableVirtualViewDebugFeatures();
}
bool JReactNativeFeatureFlagsCxxInterop::enableVirtualViewRenderState(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
return ReactNativeFeatureFlags::enableVirtualViewRenderState();
}
bool JReactNativeFeatureFlagsCxxInterop::fixMappingOfEventPrioritiesBetweenFabricAndReact(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
return ReactNativeFeatureFlags::fixMappingOfEventPrioritiesBetweenFabricAndReact();
@@ -1154,9 +1143,6 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
makeNativeMethod(
"enableVirtualViewDebugFeatures",
JReactNativeFeatureFlagsCxxInterop::enableVirtualViewDebugFeatures),
makeNativeMethod(
"enableVirtualViewRenderState",
JReactNativeFeatureFlagsCxxInterop::enableVirtualViewRenderState),
makeNativeMethod(
"fixMappingOfEventPrioritiesBetweenFabricAndReact",
JReactNativeFeatureFlagsCxxInterop::fixMappingOfEventPrioritiesBetweenFabricAndReact),
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<3b559c57fce966ad9b8ad538c2cc763b>>
* @generated SignedSource<<65067f69d2477016b20b52596e22085d>>
*/
/**
@@ -186,9 +186,6 @@ class JReactNativeFeatureFlagsCxxInterop
static bool enableVirtualViewDebugFeatures(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
static bool enableVirtualViewRenderState(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
static bool fixMappingOfEventPrioritiesBetweenFabricAndReact(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<9f8cfb9b8569ccb430bc87f6df370cb9>>
* @generated SignedSource<<4c09707a70b2e3ced763abf51b230d3c>>
*/
/**
@@ -234,10 +234,6 @@ bool ReactNativeFeatureFlags::enableVirtualViewDebugFeatures() {
return getAccessor().enableVirtualViewDebugFeatures();
}
bool ReactNativeFeatureFlags::enableVirtualViewRenderState() {
return getAccessor().enableVirtualViewRenderState();
}
bool ReactNativeFeatureFlags::fixMappingOfEventPrioritiesBetweenFabricAndReact() {
return getAccessor().fixMappingOfEventPrioritiesBetweenFabricAndReact();
}
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<66174931b6a02a4f5033789a46dcc11d>>
* @generated SignedSource<<e48f5e20876690cc1b8d74f78b721650>>
*/
/**
@@ -299,11 +299,6 @@ class ReactNativeFeatureFlags {
*/
RN_EXPORT static bool enableVirtualViewDebugFeatures();
/**
* Enables reading render state when dispatching VirtualView events.
*/
RN_EXPORT static bool enableVirtualViewRenderState();
/**
* Uses the default event priority instead of the discreet event priority by default when dispatching events from Fabric to React.
*/
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<144b4b20ba3856fa19734de44db50377>>
* @generated SignedSource<<828d9d1aafc49a5308ecc1181648cd86>>
*/
/**
@@ -965,24 +965,6 @@ bool ReactNativeFeatureFlagsAccessor::enableVirtualViewDebugFeatures() {
return flagValue.value();
}
bool ReactNativeFeatureFlagsAccessor::enableVirtualViewRenderState() {
auto flagValue = enableVirtualViewRenderState_.load();
if (!flagValue.has_value()) {
// This block is not exclusive but it is not necessary.
// If multiple threads try to initialize the feature flag, we would only
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(52, "enableVirtualViewRenderState");
flagValue = currentProvider_->enableVirtualViewRenderState();
enableVirtualViewRenderState_ = flagValue;
}
return flagValue.value();
}
bool ReactNativeFeatureFlagsAccessor::fixMappingOfEventPrioritiesBetweenFabricAndReact() {
auto flagValue = fixMappingOfEventPrioritiesBetweenFabricAndReact_.load();
@@ -992,7 +974,7 @@ bool ReactNativeFeatureFlagsAccessor::fixMappingOfEventPrioritiesBetweenFabricAn
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(53, "fixMappingOfEventPrioritiesBetweenFabricAndReact");
markFlagAsAccessed(52, "fixMappingOfEventPrioritiesBetweenFabricAndReact");
flagValue = currentProvider_->fixMappingOfEventPrioritiesBetweenFabricAndReact();
fixMappingOfEventPrioritiesBetweenFabricAndReact_ = flagValue;
@@ -1010,7 +992,7 @@ bool ReactNativeFeatureFlagsAccessor::fixTextClippingAndroid15useBoundsForWidth(
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(54, "fixTextClippingAndroid15useBoundsForWidth");
markFlagAsAccessed(53, "fixTextClippingAndroid15useBoundsForWidth");
flagValue = currentProvider_->fixTextClippingAndroid15useBoundsForWidth();
fixTextClippingAndroid15useBoundsForWidth_ = flagValue;
@@ -1028,7 +1010,7 @@ bool ReactNativeFeatureFlagsAccessor::fuseboxAssertSingleHostState() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(55, "fuseboxAssertSingleHostState");
markFlagAsAccessed(54, "fuseboxAssertSingleHostState");
flagValue = currentProvider_->fuseboxAssertSingleHostState();
fuseboxAssertSingleHostState_ = flagValue;
@@ -1046,7 +1028,7 @@ bool ReactNativeFeatureFlagsAccessor::fuseboxEnabledRelease() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(56, "fuseboxEnabledRelease");
markFlagAsAccessed(55, "fuseboxEnabledRelease");
flagValue = currentProvider_->fuseboxEnabledRelease();
fuseboxEnabledRelease_ = flagValue;
@@ -1064,7 +1046,7 @@ bool ReactNativeFeatureFlagsAccessor::fuseboxNetworkInspectionEnabled() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(57, "fuseboxNetworkInspectionEnabled");
markFlagAsAccessed(56, "fuseboxNetworkInspectionEnabled");
flagValue = currentProvider_->fuseboxNetworkInspectionEnabled();
fuseboxNetworkInspectionEnabled_ = flagValue;
@@ -1082,7 +1064,7 @@ bool ReactNativeFeatureFlagsAccessor::hideOffscreenVirtualViewsOnIOS() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(58, "hideOffscreenVirtualViewsOnIOS");
markFlagAsAccessed(57, "hideOffscreenVirtualViewsOnIOS");
flagValue = currentProvider_->hideOffscreenVirtualViewsOnIOS();
hideOffscreenVirtualViewsOnIOS_ = flagValue;
@@ -1100,7 +1082,7 @@ bool ReactNativeFeatureFlagsAccessor::overrideBySynchronousMountPropsAtMountingA
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(59, "overrideBySynchronousMountPropsAtMountingAndroid");
markFlagAsAccessed(58, "overrideBySynchronousMountPropsAtMountingAndroid");
flagValue = currentProvider_->overrideBySynchronousMountPropsAtMountingAndroid();
overrideBySynchronousMountPropsAtMountingAndroid_ = flagValue;
@@ -1118,7 +1100,7 @@ bool ReactNativeFeatureFlagsAccessor::perfIssuesEnabled() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(60, "perfIssuesEnabled");
markFlagAsAccessed(59, "perfIssuesEnabled");
flagValue = currentProvider_->perfIssuesEnabled();
perfIssuesEnabled_ = flagValue;
@@ -1136,7 +1118,7 @@ bool ReactNativeFeatureFlagsAccessor::perfMonitorV2Enabled() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(61, "perfMonitorV2Enabled");
markFlagAsAccessed(60, "perfMonitorV2Enabled");
flagValue = currentProvider_->perfMonitorV2Enabled();
perfMonitorV2Enabled_ = flagValue;
@@ -1154,7 +1136,7 @@ double ReactNativeFeatureFlagsAccessor::preparedTextCacheSize() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(62, "preparedTextCacheSize");
markFlagAsAccessed(61, "preparedTextCacheSize");
flagValue = currentProvider_->preparedTextCacheSize();
preparedTextCacheSize_ = flagValue;
@@ -1172,7 +1154,7 @@ bool ReactNativeFeatureFlagsAccessor::preventShadowTreeCommitExhaustion() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(63, "preventShadowTreeCommitExhaustion");
markFlagAsAccessed(62, "preventShadowTreeCommitExhaustion");
flagValue = currentProvider_->preventShadowTreeCommitExhaustion();
preventShadowTreeCommitExhaustion_ = flagValue;
@@ -1190,7 +1172,7 @@ bool ReactNativeFeatureFlagsAccessor::shouldPressibilityUseW3CPointerEventsForHo
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(64, "shouldPressibilityUseW3CPointerEventsForHover");
markFlagAsAccessed(63, "shouldPressibilityUseW3CPointerEventsForHover");
flagValue = currentProvider_->shouldPressibilityUseW3CPointerEventsForHover();
shouldPressibilityUseW3CPointerEventsForHover_ = flagValue;
@@ -1208,7 +1190,7 @@ bool ReactNativeFeatureFlagsAccessor::shouldResetClickableWhenRecyclingView() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(65, "shouldResetClickableWhenRecyclingView");
markFlagAsAccessed(64, "shouldResetClickableWhenRecyclingView");
flagValue = currentProvider_->shouldResetClickableWhenRecyclingView();
shouldResetClickableWhenRecyclingView_ = flagValue;
@@ -1226,7 +1208,7 @@ bool ReactNativeFeatureFlagsAccessor::shouldResetOnClickListenerWhenRecyclingVie
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(66, "shouldResetOnClickListenerWhenRecyclingView");
markFlagAsAccessed(65, "shouldResetOnClickListenerWhenRecyclingView");
flagValue = currentProvider_->shouldResetOnClickListenerWhenRecyclingView();
shouldResetOnClickListenerWhenRecyclingView_ = flagValue;
@@ -1244,7 +1226,7 @@ bool ReactNativeFeatureFlagsAccessor::shouldSetEnabledBasedOnAccessibilityState(
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(67, "shouldSetEnabledBasedOnAccessibilityState");
markFlagAsAccessed(66, "shouldSetEnabledBasedOnAccessibilityState");
flagValue = currentProvider_->shouldSetEnabledBasedOnAccessibilityState();
shouldSetEnabledBasedOnAccessibilityState_ = flagValue;
@@ -1262,7 +1244,7 @@ bool ReactNativeFeatureFlagsAccessor::shouldSetIsClickableByDefault() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(68, "shouldSetIsClickableByDefault");
markFlagAsAccessed(67, "shouldSetIsClickableByDefault");
flagValue = currentProvider_->shouldSetIsClickableByDefault();
shouldSetIsClickableByDefault_ = flagValue;
@@ -1280,7 +1262,7 @@ bool ReactNativeFeatureFlagsAccessor::shouldTriggerResponderTransferOnScrollAndr
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(69, "shouldTriggerResponderTransferOnScrollAndroid");
markFlagAsAccessed(68, "shouldTriggerResponderTransferOnScrollAndroid");
flagValue = currentProvider_->shouldTriggerResponderTransferOnScrollAndroid();
shouldTriggerResponderTransferOnScrollAndroid_ = flagValue;
@@ -1298,7 +1280,7 @@ bool ReactNativeFeatureFlagsAccessor::skipActivityIdentityAssertionOnHostPause()
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(70, "skipActivityIdentityAssertionOnHostPause");
markFlagAsAccessed(69, "skipActivityIdentityAssertionOnHostPause");
flagValue = currentProvider_->skipActivityIdentityAssertionOnHostPause();
skipActivityIdentityAssertionOnHostPause_ = flagValue;
@@ -1316,7 +1298,7 @@ bool ReactNativeFeatureFlagsAccessor::traceTurboModulePromiseRejectionsOnAndroid
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(71, "traceTurboModulePromiseRejectionsOnAndroid");
markFlagAsAccessed(70, "traceTurboModulePromiseRejectionsOnAndroid");
flagValue = currentProvider_->traceTurboModulePromiseRejectionsOnAndroid();
traceTurboModulePromiseRejectionsOnAndroid_ = flagValue;
@@ -1334,7 +1316,7 @@ bool ReactNativeFeatureFlagsAccessor::updateRuntimeShadowNodeReferencesOnCommit(
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(72, "updateRuntimeShadowNodeReferencesOnCommit");
markFlagAsAccessed(71, "updateRuntimeShadowNodeReferencesOnCommit");
flagValue = currentProvider_->updateRuntimeShadowNodeReferencesOnCommit();
updateRuntimeShadowNodeReferencesOnCommit_ = flagValue;
@@ -1352,7 +1334,7 @@ bool ReactNativeFeatureFlagsAccessor::useAlwaysAvailableJSErrorHandling() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(73, "useAlwaysAvailableJSErrorHandling");
markFlagAsAccessed(72, "useAlwaysAvailableJSErrorHandling");
flagValue = currentProvider_->useAlwaysAvailableJSErrorHandling();
useAlwaysAvailableJSErrorHandling_ = flagValue;
@@ -1370,7 +1352,7 @@ bool ReactNativeFeatureFlagsAccessor::useFabricInterop() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(74, "useFabricInterop");
markFlagAsAccessed(73, "useFabricInterop");
flagValue = currentProvider_->useFabricInterop();
useFabricInterop_ = flagValue;
@@ -1388,7 +1370,7 @@ bool ReactNativeFeatureFlagsAccessor::useNativeViewConfigsInBridgelessMode() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(75, "useNativeViewConfigsInBridgelessMode");
markFlagAsAccessed(74, "useNativeViewConfigsInBridgelessMode");
flagValue = currentProvider_->useNativeViewConfigsInBridgelessMode();
useNativeViewConfigsInBridgelessMode_ = flagValue;
@@ -1406,7 +1388,7 @@ bool ReactNativeFeatureFlagsAccessor::useShadowNodeStateOnClone() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(76, "useShadowNodeStateOnClone");
markFlagAsAccessed(75, "useShadowNodeStateOnClone");
flagValue = currentProvider_->useShadowNodeStateOnClone();
useShadowNodeStateOnClone_ = flagValue;
@@ -1424,7 +1406,7 @@ bool ReactNativeFeatureFlagsAccessor::useSharedAnimatedBackend() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(77, "useSharedAnimatedBackend");
markFlagAsAccessed(76, "useSharedAnimatedBackend");
flagValue = currentProvider_->useSharedAnimatedBackend();
useSharedAnimatedBackend_ = flagValue;
@@ -1442,7 +1424,7 @@ bool ReactNativeFeatureFlagsAccessor::useTraitHiddenOnAndroid() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(78, "useTraitHiddenOnAndroid");
markFlagAsAccessed(77, "useTraitHiddenOnAndroid");
flagValue = currentProvider_->useTraitHiddenOnAndroid();
useTraitHiddenOnAndroid_ = flagValue;
@@ -1460,7 +1442,7 @@ bool ReactNativeFeatureFlagsAccessor::useTurboModuleInterop() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(79, "useTurboModuleInterop");
markFlagAsAccessed(78, "useTurboModuleInterop");
flagValue = currentProvider_->useTurboModuleInterop();
useTurboModuleInterop_ = flagValue;
@@ -1478,7 +1460,7 @@ bool ReactNativeFeatureFlagsAccessor::useTurboModules() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(80, "useTurboModules");
markFlagAsAccessed(79, "useTurboModules");
flagValue = currentProvider_->useTurboModules();
useTurboModules_ = flagValue;
@@ -1496,7 +1478,7 @@ double ReactNativeFeatureFlagsAccessor::viewCullingOutsetRatio() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(81, "viewCullingOutsetRatio");
markFlagAsAccessed(80, "viewCullingOutsetRatio");
flagValue = currentProvider_->viewCullingOutsetRatio();
viewCullingOutsetRatio_ = flagValue;
@@ -1514,7 +1496,7 @@ double ReactNativeFeatureFlagsAccessor::virtualViewHysteresisRatio() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(82, "virtualViewHysteresisRatio");
markFlagAsAccessed(81, "virtualViewHysteresisRatio");
flagValue = currentProvider_->virtualViewHysteresisRatio();
virtualViewHysteresisRatio_ = flagValue;
@@ -1532,7 +1514,7 @@ double ReactNativeFeatureFlagsAccessor::virtualViewPrerenderRatio() {
// be accessing the provider multiple times but the end state of this
// instance and the returned flag value would be the same.
markFlagAsAccessed(83, "virtualViewPrerenderRatio");
markFlagAsAccessed(82, "virtualViewPrerenderRatio");
flagValue = currentProvider_->virtualViewPrerenderRatio();
virtualViewPrerenderRatio_ = flagValue;
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<bb6a2c318007b816305c81b046864f1f>>
* @generated SignedSource<<275c3f7a627c07f470c9ac1949d9fbcc>>
*/
/**
@@ -84,7 +84,6 @@ class ReactNativeFeatureFlagsAccessor {
bool enableViewRecyclingForView();
bool enableVirtualViewContainerStateExperimental();
bool enableVirtualViewDebugFeatures();
bool enableVirtualViewRenderState();
bool fixMappingOfEventPrioritiesBetweenFabricAndReact();
bool fixTextClippingAndroid15useBoundsForWidth();
bool fuseboxAssertSingleHostState();
@@ -127,7 +126,7 @@ class ReactNativeFeatureFlagsAccessor {
std::unique_ptr<ReactNativeFeatureFlagsProvider> currentProvider_;
bool wasOverridden_;
std::array<std::atomic<const char*>, 84> accessedFeatureFlags_;
std::array<std::atomic<const char*>, 83> accessedFeatureFlags_;
std::atomic<std::optional<bool>> commonTestFlag_;
std::atomic<std::optional<bool>> cdpInteractionMetricsEnabled_;
@@ -181,7 +180,6 @@ class ReactNativeFeatureFlagsAccessor {
std::atomic<std::optional<bool>> enableViewRecyclingForView_;
std::atomic<std::optional<bool>> enableVirtualViewContainerStateExperimental_;
std::atomic<std::optional<bool>> enableVirtualViewDebugFeatures_;
std::atomic<std::optional<bool>> enableVirtualViewRenderState_;
std::atomic<std::optional<bool>> fixMappingOfEventPrioritiesBetweenFabricAndReact_;
std::atomic<std::optional<bool>> fixTextClippingAndroid15useBoundsForWidth_;
std::atomic<std::optional<bool>> fuseboxAssertSingleHostState_;
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<a3ae8da86413406f0fde5bff362718f3>>
* @generated SignedSource<<159c2185b5aabf5bc0bb0a32fcd0473d>>
*/
/**
@@ -235,10 +235,6 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
return false;
}
bool enableVirtualViewRenderState() override {
return true;
}
bool fixMappingOfEventPrioritiesBetweenFabricAndReact() override {
return false;
}
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<69f66d45b89b38d134a6295b344d6c01>>
* @generated SignedSource<<4664498d96f4b4e3e85d96e81c981f83>>
*/
/**
@@ -513,15 +513,6 @@ class ReactNativeFeatureFlagsDynamicProvider : public ReactNativeFeatureFlagsDef
return ReactNativeFeatureFlagsDefaults::enableVirtualViewDebugFeatures();
}
bool enableVirtualViewRenderState() override {
auto value = values_["enableVirtualViewRenderState"];
if (!value.isNull()) {
return value.getBool();
}
return ReactNativeFeatureFlagsDefaults::enableVirtualViewRenderState();
}
bool fixMappingOfEventPrioritiesBetweenFabricAndReact() override {
auto value = values_["fixMappingOfEventPrioritiesBetweenFabricAndReact"];
if (!value.isNull()) {
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<6be39541927fc411650706cafbffa704>>
* @generated SignedSource<<85e69738d9f20fb3d9da17304546956c>>
*/
/**
@@ -77,7 +77,6 @@ class ReactNativeFeatureFlagsProvider {
virtual bool enableViewRecyclingForView() = 0;
virtual bool enableVirtualViewContainerStateExperimental() = 0;
virtual bool enableVirtualViewDebugFeatures() = 0;
virtual bool enableVirtualViewRenderState() = 0;
virtual bool fixMappingOfEventPrioritiesBetweenFabricAndReact() = 0;
virtual bool fixTextClippingAndroid15useBoundsForWidth() = 0;
virtual bool fuseboxAssertSingleHostState() = 0;
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<c687a5245aaad6e1faef62500ed05b72>>
* @generated SignedSource<<938d098abe72c4e65078380234d8f818>>
*/
/**
@@ -304,11 +304,6 @@ bool NativeReactNativeFeatureFlags::enableVirtualViewDebugFeatures(
return ReactNativeFeatureFlags::enableVirtualViewDebugFeatures();
}
bool NativeReactNativeFeatureFlags::enableVirtualViewRenderState(
jsi::Runtime& /*runtime*/) {
return ReactNativeFeatureFlags::enableVirtualViewRenderState();
}
bool NativeReactNativeFeatureFlags::fixMappingOfEventPrioritiesBetweenFabricAndReact(
jsi::Runtime& /*runtime*/) {
return ReactNativeFeatureFlags::fixMappingOfEventPrioritiesBetweenFabricAndReact();
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<69e867b1097632a24c71466d0baf8765>>
* @generated SignedSource<<8143c4446642b5777a48dc76172d65b6>>
*/
/**
@@ -140,8 +140,6 @@ class NativeReactNativeFeatureFlags
bool enableVirtualViewDebugFeatures(jsi::Runtime& runtime);
bool enableVirtualViewRenderState(jsi::Runtime& runtime);
bool fixMappingOfEventPrioritiesBetweenFabricAndReact(jsi::Runtime& runtime);
bool fixTextClippingAndroid15useBoundsForWidth(jsi::Runtime& runtime);
@@ -604,17 +604,6 @@ const definitions: FeatureFlagDefinitions = {
},
ossReleaseStage: 'none',
},
enableVirtualViewRenderState: {
defaultValue: true,
metadata: {
dateAdded: '2025-06-25',
description:
'Enables reading render state when dispatching VirtualView events.',
expectedReleaseValue: true,
purpose: 'experimentation',
},
ossReleaseStage: 'none',
},
fixMappingOfEventPrioritiesBetweenFabricAndReact: {
defaultValue: false,
metadata: {
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<d776ed9a554a499d29756f3ed6ab386c>>
* @generated SignedSource<<480e58e52425586928349b9f3560ce7f>>
* @flow strict
* @noformat
*/
@@ -101,7 +101,6 @@ export type ReactNativeFeatureFlags = $ReadOnly<{
enableViewRecyclingForView: Getter<boolean>,
enableVirtualViewContainerStateExperimental: Getter<boolean>,
enableVirtualViewDebugFeatures: Getter<boolean>,
enableVirtualViewRenderState: Getter<boolean>,
fixMappingOfEventPrioritiesBetweenFabricAndReact: Getter<boolean>,
fixTextClippingAndroid15useBoundsForWidth: Getter<boolean>,
fuseboxAssertSingleHostState: Getter<boolean>,
@@ -417,10 +416,6 @@ export const enableVirtualViewContainerStateExperimental: Getter<boolean> = crea
* Enables VirtualView debug features such as logging and overlays.
*/
export const enableVirtualViewDebugFeatures: Getter<boolean> = createNativeFlagGetter('enableVirtualViewDebugFeatures', false);
/**
* Enables reading render state when dispatching VirtualView events.
*/
export const enableVirtualViewRenderState: Getter<boolean> = createNativeFlagGetter('enableVirtualViewRenderState', true);
/**
* Uses the default event priority instead of the discreet event priority by default when dispatching events from Fabric to React.
*/
@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<85fa3f5ab5a3ff245aa0d89a4599fa44>>
* @generated SignedSource<<935799fffbb56ea085dca694dc8272a0>>
* @flow strict
* @noformat
*/
@@ -77,7 +77,6 @@ export interface Spec extends TurboModule {
+enableViewRecyclingForView?: () => boolean;
+enableVirtualViewContainerStateExperimental?: () => boolean;
+enableVirtualViewDebugFeatures?: () => boolean;
+enableVirtualViewRenderState?: () => boolean;
+fixMappingOfEventPrioritiesBetweenFabricAndReact?: () => boolean;
+fixTextClippingAndroid15useBoundsForWidth?: () => boolean;
+fuseboxAssertSingleHostState?: () => boolean;