mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
refactor: convert ReactPropForShadowNodeSetterTest to kotlin (#41774)
Summary: This PR convert `ReactPropForShadowNodeSetterTest` to kotlin as part of https://github.com/facebook/react-native/issues/38825 ## Changelog: [INTERNAL] [CHANGED] - Convert ReactPropForShadowNodeSetterTest to kotlin <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: https://github.com/facebook/react-native/pull/41774 Test Plan: ``` ./gradlew :packages:react-native:ReactAndroid:test ``` Reviewed By: NickGerleman Differential Revision: D51882685 Pulled By: cortinico fbshipit-source-id: ff1cce824dc342200f1f5ccbb297b955747b10c8
This commit is contained in:
Kamil
committed by
Facebook GitHub Bot
Facebook GitHub Bot
parent
38d07eb284
commit
186fc85c8f
-165
@@ -1,165 +0,0 @@
|
||||
/*
|
||||
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
|
||||
package com.facebook.react.uimanager;
|
||||
|
||||
import static org.mockito.Mockito.mock;
|
||||
import static org.mockito.Mockito.reset;
|
||||
import static org.mockito.Mockito.verify;
|
||||
import static org.mockito.Mockito.verifyNoMoreInteractions;
|
||||
|
||||
import androidx.annotation.Nullable;
|
||||
import com.facebook.react.bridge.JavaOnlyMap;
|
||||
import com.facebook.react.bridge.ReactApplicationContext;
|
||||
import com.facebook.react.bridge.ReadableArray;
|
||||
import com.facebook.react.bridge.ReadableMap;
|
||||
import com.facebook.react.uimanager.annotations.ReactProp;
|
||||
import com.facebook.react.uimanager.annotations.ReactPropGroup;
|
||||
import com.facebook.testutils.shadows.ShadowSoLoader;
|
||||
import com.facebook.testutils.shadows.ShadowYogaConfigProvider;
|
||||
import com.facebook.testutils.shadows.ShadowYogaNodeFactory;
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
import org.junit.runner.RunWith;
|
||||
import org.robolectric.RobolectricTestRunner;
|
||||
import org.robolectric.RuntimeEnvironment;
|
||||
import org.robolectric.annotation.Config;
|
||||
|
||||
/**
|
||||
* Test {@link ReactProp} annotation for {@link ReactShadowNode}. More comprehensive test of this
|
||||
* annotation can be found in {@link ReactPropAnnotationSetterTest} where we test all possible types
|
||||
* of properties to be updated.
|
||||
*/
|
||||
@RunWith(RobolectricTestRunner.class)
|
||||
@Config(
|
||||
shadows = {ShadowYogaConfigProvider.class, ShadowSoLoader.class, ShadowYogaNodeFactory.class})
|
||||
public class ReactPropForShadowNodeSetterTest {
|
||||
public interface ViewManagerUpdatesReceiver {
|
||||
void onBooleanSetterCalled(boolean value);
|
||||
|
||||
void onIntSetterCalled(int value);
|
||||
|
||||
void onDoubleSetterCalled(double value);
|
||||
|
||||
void onFloatSetterCalled(float value);
|
||||
|
||||
void onStringSetterCalled(String value);
|
||||
|
||||
void onBoxedBooleanSetterCalled(Boolean value);
|
||||
|
||||
void onBoxedIntSetterCalled(Integer value);
|
||||
|
||||
void onArraySetterCalled(ReadableArray value);
|
||||
|
||||
void onMapSetterCalled(ReadableMap value);
|
||||
|
||||
void onFloatGroupPropSetterCalled(int index, float value);
|
||||
|
||||
void onIntGroupPropSetterCalled(int index, int value);
|
||||
|
||||
void onBoxedIntGroupPropSetterCalled(int index, Integer value);
|
||||
}
|
||||
|
||||
private ReactStylesDiffMap buildStyles(Object... keysAndValues) {
|
||||
return new ReactStylesDiffMap(JavaOnlyMap.of(keysAndValues));
|
||||
}
|
||||
|
||||
private class ShadowViewUnderTest extends ReactShadowNodeImpl {
|
||||
|
||||
private ViewManagerUpdatesReceiver mViewManagerUpdatesReceiver;
|
||||
|
||||
private ShadowViewUnderTest(ViewManagerUpdatesReceiver viewManagerUpdatesReceiver) {
|
||||
mViewManagerUpdatesReceiver = viewManagerUpdatesReceiver;
|
||||
setViewClassName("ShadowViewUnderTest");
|
||||
ReactApplicationContext context =
|
||||
new ReactApplicationContext(RuntimeEnvironment.getApplication());
|
||||
setThemedContext(new ThemedReactContext(context, context, null, -1));
|
||||
}
|
||||
|
||||
@ReactProp(name = "boolProp")
|
||||
public void setBoolProp(boolean value) {
|
||||
mViewManagerUpdatesReceiver.onBooleanSetterCalled(value);
|
||||
}
|
||||
|
||||
@ReactProp(name = "stringProp")
|
||||
public void setStringProp(@Nullable String value) {
|
||||
mViewManagerUpdatesReceiver.onStringSetterCalled(value);
|
||||
}
|
||||
|
||||
@ReactProp(name = "boxedIntProp")
|
||||
public void setBoxedIntProp(@Nullable Integer value) {
|
||||
mViewManagerUpdatesReceiver.onBoxedIntSetterCalled(value);
|
||||
}
|
||||
|
||||
@ReactPropGroup(
|
||||
names = {
|
||||
"floatGroupPropFirst",
|
||||
"floatGroupPropSecond",
|
||||
})
|
||||
public void setFloatGroupProp(int index, float value) {
|
||||
mViewManagerUpdatesReceiver.onFloatGroupPropSetterCalled(index, value);
|
||||
}
|
||||
}
|
||||
|
||||
private ViewManagerUpdatesReceiver mUpdatesReceiverMock;
|
||||
private ShadowViewUnderTest mShadowView;
|
||||
|
||||
@Before
|
||||
public void setup() {
|
||||
mUpdatesReceiverMock = mock(ViewManagerUpdatesReceiver.class);
|
||||
mShadowView = new ShadowViewUnderTest(mUpdatesReceiverMock);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testBooleanSetter() {
|
||||
mShadowView.updateProperties(buildStyles("boolProp", true));
|
||||
verify(mUpdatesReceiverMock).onBooleanSetterCalled(true);
|
||||
verifyNoMoreInteractions(mUpdatesReceiverMock);
|
||||
reset(mUpdatesReceiverMock);
|
||||
|
||||
mShadowView.updateProperties(buildStyles("boolProp", false));
|
||||
verify(mUpdatesReceiverMock).onBooleanSetterCalled(false);
|
||||
verifyNoMoreInteractions(mUpdatesReceiverMock);
|
||||
reset(mUpdatesReceiverMock);
|
||||
|
||||
mShadowView.updateProperties(buildStyles("boolProp", null));
|
||||
verify(mUpdatesReceiverMock).onBooleanSetterCalled(false);
|
||||
verifyNoMoreInteractions(mUpdatesReceiverMock);
|
||||
reset(mUpdatesReceiverMock);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testStringSetter() {
|
||||
mShadowView.updateProperties(buildStyles("stringProp", "someRandomString"));
|
||||
verify(mUpdatesReceiverMock).onStringSetterCalled("someRandomString");
|
||||
verifyNoMoreInteractions(mUpdatesReceiverMock);
|
||||
reset(mUpdatesReceiverMock);
|
||||
|
||||
mShadowView.updateProperties(buildStyles("stringProp", null));
|
||||
verify(mUpdatesReceiverMock).onStringSetterCalled(null);
|
||||
verifyNoMoreInteractions(mUpdatesReceiverMock);
|
||||
reset(mUpdatesReceiverMock);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testFloatGroupSetter() {
|
||||
mShadowView.updateProperties(buildStyles("floatGroupPropFirst", 11.0));
|
||||
verify(mUpdatesReceiverMock).onFloatGroupPropSetterCalled(0, 11.0f);
|
||||
verifyNoMoreInteractions(mUpdatesReceiverMock);
|
||||
reset(mUpdatesReceiverMock);
|
||||
|
||||
mShadowView.updateProperties(buildStyles("floatGroupPropSecond", -111.0));
|
||||
verify(mUpdatesReceiverMock).onFloatGroupPropSetterCalled(1, -111.0f);
|
||||
verifyNoMoreInteractions(mUpdatesReceiverMock);
|
||||
reset(mUpdatesReceiverMock);
|
||||
|
||||
mShadowView.updateProperties(buildStyles("floatGroupPropSecond", null));
|
||||
verify(mUpdatesReceiverMock).onFloatGroupPropSetterCalled(1, 0.0f);
|
||||
verifyNoMoreInteractions(mUpdatesReceiverMock);
|
||||
reset(mUpdatesReceiverMock);
|
||||
}
|
||||
}
|
||||
+154
@@ -0,0 +1,154 @@
|
||||
/*
|
||||
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
|
||||
package com.facebook.react.uimanager
|
||||
|
||||
import com.facebook.react.bridge.JavaOnlyMap
|
||||
import com.facebook.react.bridge.ReactApplicationContext
|
||||
import com.facebook.react.bridge.ReadableArray
|
||||
import com.facebook.react.bridge.ReadableMap
|
||||
import com.facebook.react.uimanager.annotations.ReactProp
|
||||
import com.facebook.react.uimanager.annotations.ReactPropGroup
|
||||
import com.facebook.testutils.shadows.ShadowSoLoader
|
||||
import com.facebook.testutils.shadows.ShadowYogaConfigProvider
|
||||
import com.facebook.testutils.shadows.ShadowYogaNodeFactory
|
||||
import org.junit.Before
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
import org.mockito.Mockito.mock
|
||||
import org.mockito.Mockito.reset
|
||||
import org.mockito.Mockito.verify
|
||||
import org.mockito.Mockito.verifyNoMoreInteractions
|
||||
import org.robolectric.RobolectricTestRunner
|
||||
import org.robolectric.RuntimeEnvironment
|
||||
import org.robolectric.annotation.Config
|
||||
|
||||
/** Test [ReactProp] and [ReactPropGroup] annotations for [ReactShadowNode] */
|
||||
@RunWith(RobolectricTestRunner::class)
|
||||
@Config(
|
||||
shadows =
|
||||
[ShadowYogaConfigProvider::class, ShadowSoLoader::class, ShadowYogaNodeFactory::class])
|
||||
class ReactPropForShadowNodeSetterTest {
|
||||
interface ViewManagerUpdatesReceiver {
|
||||
fun onBooleanSetterCalled(value: Boolean)
|
||||
|
||||
fun onIntSetterCalled(value: Int)
|
||||
|
||||
fun onDoubleSetterCalled(value: Double)
|
||||
|
||||
fun onFloatSetterCalled(value: Float)
|
||||
|
||||
fun onStringSetterCalled(value: String?)
|
||||
|
||||
fun onBoxedBooleanSetterCalled(value: Boolean?)
|
||||
|
||||
fun onBoxedIntSetterCalled(value: Int?)
|
||||
|
||||
fun onArraySetterCalled(value: ReadableArray?)
|
||||
|
||||
fun onMapSetterCalled(value: ReadableMap?)
|
||||
|
||||
fun onFloatGroupPropSetterCalled(index: Int, value: Float)
|
||||
|
||||
fun onIntGroupPropSetterCalled(index: Int, value: Int)
|
||||
|
||||
fun onBoxedIntGroupPropSetterCalled(index: Int, value: Int?)
|
||||
}
|
||||
|
||||
private inner class ShadowViewUnderTest(
|
||||
val viewManagerUpdatesReceiver: ViewManagerUpdatesReceiver
|
||||
) : ReactShadowNodeImpl() {
|
||||
|
||||
init {
|
||||
setViewClassName("ShadowViewUnderTest")
|
||||
val context = ReactApplicationContext(RuntimeEnvironment.getApplication())
|
||||
setThemedContext(ThemedReactContext(context, context, null, -1))
|
||||
}
|
||||
|
||||
@ReactProp(name = "boolProp")
|
||||
fun setBoolProp(value: Boolean) {
|
||||
viewManagerUpdatesReceiver.onBooleanSetterCalled(value)
|
||||
}
|
||||
|
||||
@ReactProp(name = "stringProp")
|
||||
fun setStringProp(value: String?) {
|
||||
viewManagerUpdatesReceiver.onStringSetterCalled(value)
|
||||
}
|
||||
|
||||
@ReactProp(name = "boxedIntProp")
|
||||
fun setBoxedIntProp(value: Int?) {
|
||||
viewManagerUpdatesReceiver.onBoxedIntSetterCalled(value)
|
||||
}
|
||||
|
||||
@ReactPropGroup(names = ["floatGroupPropFirst", "floatGroupPropSecond"])
|
||||
fun setFloatGroupProp(index: Int, value: Float) {
|
||||
viewManagerUpdatesReceiver.onFloatGroupPropSetterCalled(index, value)
|
||||
}
|
||||
}
|
||||
|
||||
private lateinit var shadowView: ShadowViewUnderTest
|
||||
private lateinit var updatesReceiverMock: ViewManagerUpdatesReceiver
|
||||
|
||||
@Before
|
||||
fun setup() {
|
||||
updatesReceiverMock = mock(ViewManagerUpdatesReceiver::class.java)
|
||||
shadowView = ShadowViewUnderTest(updatesReceiverMock)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun testBooleanSetter() {
|
||||
shadowView.updateProperties(buildStyles("boolProp", true))
|
||||
verify(updatesReceiverMock).onBooleanSetterCalled(true)
|
||||
verifyNoMoreInteractions(updatesReceiverMock)
|
||||
reset(updatesReceiverMock)
|
||||
|
||||
shadowView.updateProperties(buildStyles("boolProp", false))
|
||||
verify(updatesReceiverMock).onBooleanSetterCalled(false)
|
||||
verifyNoMoreInteractions(updatesReceiverMock)
|
||||
reset(updatesReceiverMock)
|
||||
|
||||
shadowView.updateProperties(buildStyles("boolProp", null))
|
||||
verify(updatesReceiverMock).onBooleanSetterCalled(false)
|
||||
verifyNoMoreInteractions(updatesReceiverMock)
|
||||
reset(updatesReceiverMock)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun testStringSetter() {
|
||||
shadowView.updateProperties(buildStyles("stringProp", "someRandomString"))
|
||||
verify(updatesReceiverMock).onStringSetterCalled("someRandomString")
|
||||
verifyNoMoreInteractions(updatesReceiverMock)
|
||||
reset(updatesReceiverMock)
|
||||
|
||||
shadowView.updateProperties(buildStyles("stringProp", null))
|
||||
verify(updatesReceiverMock).onStringSetterCalled(null)
|
||||
verifyNoMoreInteractions(updatesReceiverMock)
|
||||
reset(updatesReceiverMock)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun testFloatGroupSetter() {
|
||||
shadowView.updateProperties(buildStyles("floatGroupPropFirst", 11.0))
|
||||
verify(updatesReceiverMock).onFloatGroupPropSetterCalled(0, 11.0f)
|
||||
verifyNoMoreInteractions(updatesReceiverMock)
|
||||
reset(updatesReceiverMock)
|
||||
|
||||
shadowView.updateProperties(buildStyles("floatGroupPropSecond", -111.0))
|
||||
verify(updatesReceiverMock).onFloatGroupPropSetterCalled(1, -111.0f)
|
||||
verifyNoMoreInteractions(updatesReceiverMock)
|
||||
reset(updatesReceiverMock)
|
||||
|
||||
shadowView.updateProperties(buildStyles("floatGroupPropSecond", null))
|
||||
verify(updatesReceiverMock).onFloatGroupPropSetterCalled(1, 0.0f)
|
||||
verifyNoMoreInteractions(updatesReceiverMock)
|
||||
reset(updatesReceiverMock)
|
||||
}
|
||||
|
||||
companion object {
|
||||
fun buildStyles(vararg keysAndValues: Any?) = ReactStylesDiffMap(JavaOnlyMap.of(*keysAndValues))
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user