mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Summary:
This partially reverts commit 58adc5e4b9.
Using an absolute path in a podspec is wrong, and causes checksum issues when installs are ran on different systems.
Example:
`pod install --deployment --clean-install` breaks on non-matching checksums on CI because the absolute path is not the same in that environment.
```
Adding spec repo `trunk` with CDN `https://cdn.cocoapods.org/`
Verifying no changes
[!] There were changes to the lockfile in deployment mode:
SPEC CHECKSUMS:
React-debug:
New Lockfile: 419922cde6c58cd5b9d43e4a09805146a7dd13a8
Old Lockfile: 1ce329843d8f9a9cbe0cdd9de264b20e89586734
React-NativeModulesApple:
New Lockfile: a683b0c999e76b7d15ad9d5eaf8b6308e710a93e
Old Lockfile: f82356d67a137295d098a98a03be5ee35871b5a5
React-runtimescheduler:
New Lockfile: 79f8dff11acbe36aaeece63553680d7a8272af96
Old Lockfile: 16c5282d43a0df50d7c68ebf0218aeeb642a7086
React-utils:
New Lockfile: 4fabb3cba786651e35bc41e610b0698fa24cecff
Old Lockfile: e7e9118d0e85b107bb06d1a5f72ec5db6bddb911
ReactCommon:
New Lockfile: af30fb021799e18c85a8e30ce799e15607e82212
Old Lockfile: f04f86f33c22e05dbf875789ea522ee486dace78
```
And even tho the change fixed an issue with pnpm, the issue it introduces with cocoapods I think is a bigger one.
## Changelog:
[INTERNAL] - Revert commit that makes podfile unstable
Pull Request resolved: https://github.com/facebook/react-native/pull/39177
Test Plan: Tested locally that the hashes are stable
Reviewed By: NickGerleman
Differential Revision: D48773887
Pulled By: cipolleschi
fbshipit-source-id: 96bcdbadc17a24fa9a8669f569d004bee6a03521
This commit is contained in:
committed by
Facebook GitHub Bot
parent
468a13635a
commit
16fc065aa1
@@ -37,7 +37,7 @@ Pod::Spec.new do |s|
|
||||
"DEFINES_MODULE" => "YES" }
|
||||
|
||||
if ENV['USE_FRAMEWORKS']
|
||||
s.header_mappings_dir = File.absolute_path('./')
|
||||
s.header_mappings_dir = './'
|
||||
s.module_name = 'React_Fabric'
|
||||
end
|
||||
|
||||
|
||||
@@ -37,7 +37,7 @@ Pod::Spec.new do |s|
|
||||
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17",
|
||||
"GCC_WARN_PEDANTIC" => "YES" }
|
||||
if ENV['USE_FRAMEWORKS']
|
||||
s.header_mappings_dir = File.absolute_path("./")
|
||||
s.header_mappings_dir = './'
|
||||
end
|
||||
|
||||
# TODO (T48588859): Restructure this target to align with dir structure: "react/nativemodule/..."
|
||||
|
||||
@@ -32,6 +32,6 @@ Pod::Spec.new do |s|
|
||||
|
||||
if ENV['USE_FRAMEWORKS']
|
||||
s.module_name = "React_debug"
|
||||
s.header_mappings_dir = File.absolute_path("../..")
|
||||
s.header_mappings_dir = "../.."
|
||||
end
|
||||
end
|
||||
|
||||
+1
-1
@@ -37,7 +37,7 @@ Pod::Spec.new do |s|
|
||||
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17",
|
||||
"GCC_WARN_PEDANTIC" => "YES" }
|
||||
if ENV['USE_FRAMEWORKS']
|
||||
s.header_mappings_dir = File.absolute_path('./')
|
||||
s.header_mappings_dir = './'
|
||||
end
|
||||
|
||||
s.source_files = "ReactCommon/**/*.{mm,cpp,h}"
|
||||
|
||||
+1
-1
@@ -37,7 +37,7 @@ Pod::Spec.new do |s|
|
||||
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17",
|
||||
"GCC_WARN_PEDANTIC" => "YES" }
|
||||
if ENV['USE_FRAMEWORKS']
|
||||
s.header_mappings_dir = File.absolute_path('./')
|
||||
s.header_mappings_dir = './'
|
||||
end
|
||||
|
||||
|
||||
|
||||
@@ -45,7 +45,7 @@ Pod::Spec.new do |s|
|
||||
|
||||
if ENV['USE_FRAMEWORKS']
|
||||
s.module_name = "React_graphics"
|
||||
s.header_mappings_dir = File.absolute_path("../../..")
|
||||
s.header_mappings_dir = "../../.."
|
||||
header_search_paths = header_search_paths + ["\"$(PODS_TARGET_SRCROOT)/platform/ios\""]
|
||||
end
|
||||
|
||||
|
||||
+1
-1
@@ -42,7 +42,7 @@ Pod::Spec.new do |s|
|
||||
|
||||
if ENV['USE_FRAMEWORKS']
|
||||
s.module_name = "React_ImageManager"
|
||||
s.header_mappings_dir = File.absolute_path("./")
|
||||
s.header_mappings_dir = "./"
|
||||
header_search_paths = header_search_paths + [
|
||||
"\"${PODS_CONFIGURATION_BUILD_DIR}/React-Fabric/React_Fabric.framework/Headers\"",
|
||||
"\"$(PODS_ROOT)/DoubleConversion\"",
|
||||
|
||||
+1
-1
@@ -48,7 +48,7 @@ Pod::Spec.new do |s|
|
||||
|
||||
if ENV['USE_FRAMEWORKS']
|
||||
s.module_name = "React_runtimescheduler"
|
||||
s.header_mappings_dir = File.absolute_path("../../..")
|
||||
s.header_mappings_dir = "../../.."
|
||||
end
|
||||
|
||||
s.dependency "React-jsi"
|
||||
|
||||
@@ -48,7 +48,7 @@ Pod::Spec.new do |s|
|
||||
|
||||
if ENV['USE_FRAMEWORKS']
|
||||
s.module_name = "React_utils"
|
||||
s.header_mappings_dir = File.absolute_path("../..")
|
||||
s.header_mappings_dir = "../.."
|
||||
end
|
||||
|
||||
s.dependency "RCT-Folly", folly_version
|
||||
|
||||
Reference in New Issue
Block a user