Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Unify ImageManager API (#52749)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/52749

Changelog: [Internal]

The overloaded

```
  virtual ImageRequest requestImage(
      const ImageSource& imageSource,
      SurfaceId surfaceId) const;

  virtual ImageRequest requestImage(
      const ImageSource& imageSource,
      SurfaceId surfaceId,
      const ImageRequestParams& imageRequestParams,
      Tag tag) const;
```
can be expressed with default args in the header file
```
 virtual ImageRequest requestImage(
      const ImageSource& imageSource,
      SurfaceId surfaceId,
      const ImageRequestParams& imageRequestParams = {},
      Tag tag = {}) const;
```

Reviewed By: lenaic

Differential Revision: D78702755

fbshipit-source-id: b482a26136cd512232b86e4b86607d44ca49460e
This commit is contained in:
Christoph Purrer
2025-07-22 19:45:27 -07:00
committed by Facebook GitHub Bot
parent 174ea179cd
commit 14986a8dbf
5 changed files with 4 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactCommon/react/renderer/components/image/ImageShadowNode.cpp
+2 -9
View File
@@ -71,17 +71,10 @@ void ImageShadowNode::updateStateIfNeeded() {
return;
}
auto state = ImageState{
ImageState state{
newImageSource,
imageManager_->requestImage(
newImageSource,
getSurfaceId()
#ifdef ANDROID
,
newImageRequestParams,
getTag()
#endif
),
newImageSource, getSurfaceId(), newImageRequestParams, getTag()),
newImageRequestParams};
setStateData(std::move(state));
}
packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h
+2 -6
View File
@@ -24,15 +24,11 @@ class ImageManager {
ImageManager(const std::shared_ptr<const ContextContainer>& contextContainer);
virtual ~ImageManager();
virtual ImageRequest requestImage(
const ImageSource& imageSource,
SurfaceId surfaceId) const;
virtual ImageRequest requestImage(
const ImageSource& imageSource,
SurfaceId surfaceId,
const ImageRequestParams& imageRequestParams,
Tag tag) const;
const ImageRequestParams& imageRequestParams = {},
Tag tag = {}) const;
private:
void* self_{};
packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageManager.cpp
-6
View File
@@ -20,12 +20,6 @@ ImageManager::~ImageManager() {
delete static_cast<ImageFetcher*>(self_);
}
ImageRequest ImageManager::requestImage(
const ImageSource& imageSource,
SurfaceId surfaceId) const {
return requestImage(imageSource, surfaceId, ImageRequestParams{}, {});
}
ImageRequest ImageManager::requestImage(
const ImageSource& imageSource,
SurfaceId surfaceId,
packages/react-native/ReactCommon/react/renderer/imagemanager/platform/cxx/react/renderer/imagemanager/ImageManager.cpp
-6
View File
@@ -20,12 +20,6 @@ ImageManager::~ImageManager() {
// Not implemented.
}
ImageRequest ImageManager::requestImage(
const ImageSource& imageSource,
SurfaceId surfaceId) const {
return requestImage(imageSource, surfaceId, ImageRequestParams{}, {});
}
ImageRequest ImageManager::requestImage(
const ImageSource& imageSource,
SurfaceId /*surfaceId*/,
packages/react-native/ReactCommon/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/ImageManager.mm
-5
View File
@@ -34,11 +34,6 @@ ImageManager::~ImageManager()
self_ = nullptr;
}
ImageRequest ImageManager::requestImage(const ImageSource &imageSource, SurfaceId surfaceId) const
{
return requestImage(imageSource, surfaceId, ImageRequestParams{}, {});
}
ImageRequest ImageManager::requestImage(
const ImageSource &imageSource,
SurfaceId surfaceId,