Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Delete ReactFeatureFlags.useViewManagerDelegatesForCommands

Browse Source 
Summary:
This diff deletes ReactFeatureFlags.useViewManagerDelegatesForCommands, this has been enabled in prod for 9+ months

changelog: [internal] internal

Reviewed By: JoshuaGross

Differential Revision: D28265338

fbshipit-source-id: 2f07cb83d6ef9191f9ebea52e230490ef98d6e2d
This commit is contained in:
David Vacca
2021-05-10 15:57:43 -07:00
committed by Facebook GitHub Bot
parent 0ef5beee85
commit 13169f0987
2 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java
-7
View File
@@ -38,13 +38,6 @@ public class ReactFeatureFlags {
*/
public static boolean enableFabricLogs = false;
/**
* Should this application use a {@link com.facebook.react.uimanager.ViewManagerDelegate} (if
* provided) to execute the view commands. If {@code false}, then {@code receiveCommand} method
* inside view manager will be called instead.
*/
public static boolean useViewManagerDelegatesForCommands = false;
/**
* Temporary feature flat to control a fix in the transition to layoutOnlyViews TODO T61185028:
* remove this when bug is fixed
ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyManager.java
+2 -4
View File
@@ -30,7 +30,6 @@ import com.facebook.react.bridge.RetryableMountingLayerException;
import com.facebook.react.bridge.SoftAssertions;
import com.facebook.react.bridge.UiThreadUtil;
import com.facebook.react.common.build.ReactBuildConfig;
import com.facebook.react.config.ReactFeatureFlags;
import com.facebook.react.touch.JSResponderHandler;
import com.facebook.react.uimanager.layoutanimation.LayoutAnimationController;
import com.facebook.react.uimanager.layoutanimation.LayoutAnimationListener;
@@ -852,9 +851,8 @@ public class NativeViewHierarchyManager {
+ commandId);
}
ViewManager viewManager = resolveViewManager(reactTag);
ViewManagerDelegate delegate;
if (ReactFeatureFlags.useViewManagerDelegatesForCommands
&& (delegate = viewManager.getDelegate()) != null) {
ViewManagerDelegate delegate = viewManager.getDelegate();
if (delegate != null) {
delegate.receiveCommand(view, commandId, args);
} else {
viewManager.receiveCommand(view, commandId, args);