From 13169f0987a6fd9ed77f762339c489afd8de05e8 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Mon, 10 May 2021 15:56:34 -0700 Subject: [PATCH] Delete ReactFeatureFlags.useViewManagerDelegatesForCommands Summary: This diff deletes ReactFeatureFlags.useViewManagerDelegatesForCommands, this has been enabled in prod for 9+ months changelog: [internal] internal Reviewed By: JoshuaGross Differential Revision: D28265338 fbshipit-source-id: 2f07cb83d6ef9191f9ebea52e230490ef98d6e2d --- .../java/com/facebook/react/config/ReactFeatureFlags.java | 7 ------- .../react/uimanager/NativeViewHierarchyManager.java | 6 ++---- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java b/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java index a2d04534a75..b72b9a61359 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java +++ b/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java @@ -38,13 +38,6 @@ public class ReactFeatureFlags { */ public static boolean enableFabricLogs = false; - /** - * Should this application use a {@link com.facebook.react.uimanager.ViewManagerDelegate} (if - * provided) to execute the view commands. If {@code false}, then {@code receiveCommand} method - * inside view manager will be called instead. - */ - public static boolean useViewManagerDelegatesForCommands = false; - /** * Temporary feature flat to control a fix in the transition to layoutOnlyViews TODO T61185028: * remove this when bug is fixed diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyManager.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyManager.java index e429eba16a8..5ca18f60b05 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyManager.java @@ -30,7 +30,6 @@ import com.facebook.react.bridge.RetryableMountingLayerException; import com.facebook.react.bridge.SoftAssertions; import com.facebook.react.bridge.UiThreadUtil; import com.facebook.react.common.build.ReactBuildConfig; -import com.facebook.react.config.ReactFeatureFlags; import com.facebook.react.touch.JSResponderHandler; import com.facebook.react.uimanager.layoutanimation.LayoutAnimationController; import com.facebook.react.uimanager.layoutanimation.LayoutAnimationListener; @@ -852,9 +851,8 @@ public class NativeViewHierarchyManager { + commandId); } ViewManager viewManager = resolveViewManager(reactTag); - ViewManagerDelegate delegate; - if (ReactFeatureFlags.useViewManagerDelegatesForCommands - && (delegate = viewManager.getDelegate()) != null) { + ViewManagerDelegate delegate = viewManager.getDelegate(); + if (delegate != null) { delegate.receiveCommand(view, commandId, args); } else { viewManager.receiveCommand(view, commandId, args);