Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

NativeAnimatedModule in Fabric no longer crashes if all Animated nodes are not visited

Browse Source 
Summary:
Previously this was crashing only in debug, but that's too noisy and isn't giving us any value for now.

Changelog: [Internal]

Differential Revision: D23338800

fbshipit-source-id: bf1535cdda231ccf30af6d00509eec1499a552a1
This commit is contained in:
Joshua Gross
2020-08-27 01:32:08 -07:00
committed by Facebook GitHub Bot
parent 5e04e932a8
commit 0fb7f5a6f5
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedNodesManager.java
+5 -2
View File
@@ -718,10 +718,13 @@ import java.util.Queue;
+ " but toposort visited only "
+ updatedNodesCount);
if (mEventListenerInitializedForFabric && cyclesDetected == 0) {
// TODO T71377544: investigate these SoftExceptions and see if we can remove entirely
// or fix the root cause
ReactSoftException.logSoftException(TAG, new ReactNoCrashSoftException(ex));
} else if (mEventListenerInitializedForFabric) {
// Crashes in Debug, but not in Production
ReactSoftException.logSoftException(TAG, ex);
// TODO T71377544: investigate these SoftExceptions and see if we can remove entirely
// or fix the root cause
ReactSoftException.logSoftException(TAG, new ReactNoCrashSoftException(ex));
} else {
throw ex;
}