From 0fb7f5a6f50d66e600924cf37ee679997854779f Mon Sep 17 00:00:00 2001 From: Joshua Gross Date: Thu, 27 Aug 2020 01:30:08 -0700 Subject: [PATCH] NativeAnimatedModule in Fabric no longer crashes if all Animated nodes are not visited Summary: Previously this was crashing only in debug, but that's too noisy and isn't giving us any value for now. Changelog: [Internal] Differential Revision: D23338800 fbshipit-source-id: bf1535cdda231ccf30af6d00509eec1499a552a1 --- .../react/animated/NativeAnimatedNodesManager.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedNodesManager.java b/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedNodesManager.java index b02da661b61..9bf6d02fd2a 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedNodesManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedNodesManager.java @@ -718,10 +718,13 @@ import java.util.Queue; + " but toposort visited only " + updatedNodesCount); if (mEventListenerInitializedForFabric && cyclesDetected == 0) { + // TODO T71377544: investigate these SoftExceptions and see if we can remove entirely + // or fix the root cause ReactSoftException.logSoftException(TAG, new ReactNoCrashSoftException(ex)); } else if (mEventListenerInitializedForFabric) { - // Crashes in Debug, but not in Production - ReactSoftException.logSoftException(TAG, ex); + // TODO T71377544: investigate these SoftExceptions and see if we can remove entirely + // or fix the root cause + ReactSoftException.logSoftException(TAG, new ReactNoCrashSoftException(ex)); } else { throw ex; }