Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor: ReactInstance: Move UIManager bindings to Fabric section (#42205)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/42205

This diff should not change any behaviour.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D52399004

fbshipit-source-id: ce7906a1c14aafd1aee25d105244fca5b859c142
This commit is contained in:
Ramanpreet Nara
2024-01-10 12:35:33 -08:00
committed by Facebook GitHub Bot
parent c7873b77b8
commit 0df4511839
1 changed files with 20 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactInstance.java
+20 -21
View File
@@ -187,23 +187,6 @@ final class ReactInstance {
isProfiling,
useModernRuntimeScheduler);
RuntimeExecutor unbufferedRuntimeExecutor = getUnbufferedRuntimeExecutor();
// Initialize function for JS's UIManager.hasViewManagerConfig()
mComponentNameResolverManager =
new ComponentNameResolverManager(
// Use unbuffered RuntimeExecutor to install binding
unbufferedRuntimeExecutor,
(ComponentNameResolver)
() -> {
Collection<String> viewManagerNames = getViewManagerNames();
if (viewManagerNames.size() < 1) {
FLog.e(TAG, "No ViewManager names found");
return new String[0];
}
return viewManagerNames.toArray(new String[0]);
});
// Set up TurboModules
Systrace.beginSection(
Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "ReactInstance.initialize#initTurboModules");
@@ -222,6 +205,7 @@ final class ReactInstance {
.setReactApplicationContext(mBridgelessReactContext)
.build();
RuntimeExecutor unbufferedRuntimeExecutor = getUnbufferedRuntimeExecutor();
mTurboModuleManager =
new TurboModuleManager(
// Use unbuffered RuntimeExecutor to install binding
@@ -237,6 +221,25 @@ final class ReactInstance {
Systrace.endSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE);
// Set up Fabric
Systrace.beginSection(
Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "ReactInstance.initialize#initFabric");
// Initialize function for JS's UIManager.hasViewManagerConfig()
mComponentNameResolverManager =
new ComponentNameResolverManager(
// Use unbuffered RuntimeExecutor to install binding
unbufferedRuntimeExecutor,
(ComponentNameResolver)
() -> {
Collection<String> viewManagerNames = getViewManagerNames();
if (viewManagerNames.size() < 1) {
FLog.e(TAG, "No ViewManager names found");
return new String[0];
}
return viewManagerNames.toArray(new String[0]);
});
// Initialize function for JS's UIManager.getViewManagerConfig()
// It should come after getTurboModuleManagerDelegate as it relies on react packages being
// initialized.
@@ -258,10 +261,6 @@ final class ReactInstance {
});
}
// Set up Fabric
Systrace.beginSection(
Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "ReactInstance.initialize#initFabric");
ViewManagerRegistry viewManagerRegistry =
new ViewManagerRegistry(
new ViewManagerResolver() {