mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Handle OutOfMemoryError in NetworkingModule response processing (#56630)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56630 Catch `OutOfMemoryError` in the `onResponse` callback's response processing try-catch block in `NetworkingModule.kt`. Previously, only `IOException` was caught — `OutOfMemoryError` (which extends `Error`, not `Exception`) would propagate uncaught and crash the app. When the Java heap is near its limit (e.g., 256MB with <1% free), any allocation during response processing (buffer creation in `readWithProgress`, `responseBody.bytes()`, `responseBody.string()`) can trigger OOM. The fix converts this to a network request error event sent to JS, allowing the app to handle the failure gracefully (retry, show error message) instead of crashing. **Crash:** `android_crash:java.lang.OutOfMemoryError:com.oculus.igvr` **MID:** `024a57cfb70eef9a61af42d845c981a1` — 246 crashes in 7 days **Task:** T212267841 Logview link: [024a57cfb70eef9a61af42d845c981a1](https://www.internalfb.com/logview/system_vros_crashes/024a57cfb70eef9a61af42d845c981a1) Changelog: [Android][Fixed] - Catch OutOfMemoryError in NetworkingModule response processing to prevent app crashes Reviewed By: cortinico Differential Revision: D102236869 fbshipit-source-id: de6624640b3f2343ca8e516fe7677eecae23a932
This commit is contained in:
1 parent
c20a58ab6b
commit
0c153e2971
1 file changed
+8
+8
@@ -773,6 +773,14 @@ public class NetworkingModule(
|
||||
e.message,
|
||||
e,
|
||||
)
|
||||
} catch (e: OutOfMemoryError) {
|
||||
NetworkEventUtil.onRequestError(
|
||||
reactApplicationContext,
|
||||
requestId,
|
||||
devToolsRequestId,
|
||||
"Out of memory while processing network response",
|
||||
null,
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user