Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Skip flaky unmounted.measureInWindow(...) does nothing test on Windows (#36950)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/36950

This test is flaky and is being reported on a number of diffs: D44729814
I'm suppressing it on Windows only as it's not failing on other platforms.

Changelog:
[Internal] [Changed] - Skip flaky `unmounted.measureInWindow(...) does nothing` test on Windows

Reviewed By: sshic

Differential Revision: D45081060

fbshipit-source-id: 917018d5e4a3298c7e4dee8658a41e2b18f68bb1
This commit is contained in:
Nicola Corti
2023-04-18 06:41:42 -07:00
committed by Facebook GitHub Bot
parent d97cca3d71
commit 0c0dc1dbda
1 changed files with 19 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-test.js
Vendored
+19 -11
View File
@@ -20,6 +20,11 @@ const ReactNativeViewConfigRegistry = require('../../../Renderer/shims/ReactNati
const FabricUIManager = require('../../FabricUIManager');
const nullthrows = require('nullthrows');
const isWindows = process.platform === 'win32';
const itif = (condition: boolean) => {
return condition ? it : it.skip;
};
jest.mock('../../FabricUIManager', () =>
require('../../__mocks__/FabricUIManager'),
);
@@ -179,7 +184,7 @@ async function mockRenderKeys(
});
describe('measureInWindow', () => {
test('component.measureInWindow(...) invokes callback', async () => {
it('component.measureInWindow(...) invokes callback', async () => {
const result = await mockRenderKeys([['foo']]);
const fooRef = nullthrows(result?.[0]?.[0]);
@@ -192,18 +197,21 @@ async function mockRenderKeys(
expect(callback.mock.calls).toEqual([[10, 10, 100, 100]]);
});
test('unmounted.measureInWindow(...) does nothing', async () => {
const result = await mockRenderKeys([['foo'], null]);
const fooRef = nullthrows(result?.[0]?.[0]);
itif(!isWindows)(
'unmounted.measureInWindow(...) does nothing',
async () => {
const result = await mockRenderKeys([['foo'], null]);
const fooRef = nullthrows(result?.[0]?.[0]);
const callback = jest.fn();
fooRef.measureInWindow(callback);
const callback = jest.fn();
fooRef.measureInWindow(callback);
expect(
nullthrows(FabricUIManager.getFabricUIManager()).measureInWindow,
).not.toHaveBeenCalled();
expect(callback).not.toHaveBeenCalled();
});
expect(
nullthrows(FabricUIManager.getFabricUIManager()).measureInWindow,
).not.toHaveBeenCalled();
expect(callback).not.toHaveBeenCalled();
},
);
});
describe('measureLayout', () => {