Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move Libraries/Inspector/ to src/private/ (#49022)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/49022

These modules support the in-app Inspector Overlay.

Breaking change that's unlikely to hit any users. Unreferenced by Expo.

Changelog:
[General][Breaking] Move `Libraries/Inspector/` modules to `src/private/`

Reviewed By: cortinico

Differential Revision: D68781896

fbshipit-source-id: 8fcd72d56684319019f64a375c2e2ef317a47c13
This commit is contained in:
Alex Hunt
2025-01-29 09:56:54 -08:00
committed by Facebook GitHub Bot
parent 9a9aa19387
commit 0bde08fe67
15 changed files with 75 additions and 290 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/ReactNative/AppContainer-dev.js
Vendored
+2 -2
View File
@@ -52,7 +52,7 @@ const InspectorDeferred = ({
}: InspectorDeferredProps) => {
// D39382967 adds a require cycle: InitializeCore -> AppContainer -> Inspector -> InspectorPanel -> ScrollView -> InitializeCore
// We can't remove it yet, fallback to dynamic require for now. This is the only reason why this logic is in a separate function.
const Inspector = require('../Inspector/Inspector').default;
const Inspector = require('../../src/private/inspector/Inspector').default;
return (
<Inspector
@@ -73,7 +73,7 @@ const ReactDevToolsOverlayDeferred = ({
reactDevToolsAgent,
}: ReactDevToolsOverlayDeferredProps) => {
const ReactDevToolsOverlay =
require('../Inspector/ReactDevToolsOverlay').default;
require('../../src/private/inspector/ReactDevToolsOverlay').default;
return (
<ReactDevToolsOverlay
packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap
-222
View File
@@ -5135,228 +5135,6 @@ declare module.exports: resolveAssetSource;
"
`;
exports[`public API should not change unintentionally Libraries/Inspector/BorderBox.js 1`] = `
"type Props = $ReadOnly<{
children: React.Node,
box?: ?$ReadOnly<{
top: number,
right: number,
bottom: number,
left: number,
...
}>,
style?: ViewStyleProp,
}>;
declare function BorderBox(Props): React.Node;
declare export default typeof BorderBox;
"
`;
exports[`public API should not change unintentionally Libraries/Inspector/BoxInspector.js 1`] = `
"type BoxInspectorProps = $ReadOnly<{
style: ViewStyleProp,
frame: ?InspectedElementFrame,
}>;
declare function BoxInspector(BoxInspectorProps): React.Node;
declare export default typeof BoxInspector;
"
`;
exports[`public API should not change unintentionally Libraries/Inspector/ElementBox.js 1`] = `
"type Props = $ReadOnly<{
frame: InspectedElementFrame,
style?: ?ViewStyleProp,
}>;
declare function ElementBox(Props): React.Node;
declare export default typeof ElementBox;
"
`;
exports[`public API should not change unintentionally Libraries/Inspector/ElementProperties.js 1`] = `
"type Props = $ReadOnly<{
hierarchy: ?InspectorData[\\"hierarchy\\"],
style?: ?ViewStyleProp,
frame?: ?Object,
selection?: ?number,
setSelection?: (number) => mixed,
}>;
declare class ElementProperties extends React.Component<Props> {
render(): React.Node;
}
declare export default typeof ElementProperties;
"
`;
exports[`public API should not change unintentionally Libraries/Inspector/Inspector.js 1`] = `
"export type InspectedElementFrame = TouchedViewDataAtPoint[\\"frame\\"];
export type InspectedElement = $ReadOnly<{
frame: InspectedElementFrame,
style?: ViewStyleProp,
}>;
export type ElementsHierarchy = InspectorData[\\"hierarchy\\"];
type Props = {
inspectedViewRef: InspectedViewRef,
onRequestRerenderApp: () => void,
reactDevToolsAgent?: ReactDevToolsAgent,
};
declare function Inspector(Props): React.Node;
declare export default typeof Inspector;
"
`;
exports[`public API should not change unintentionally Libraries/Inspector/InspectorOverlay.js 1`] = `
"type Props = $ReadOnly<{
inspected?: ?InspectedElement,
onTouchPoint: (locationX: number, locationY: number) => void,
}>;
declare function InspectorOverlay(Props): React.Node;
declare export default typeof InspectorOverlay;
"
`;
exports[`public API should not change unintentionally Libraries/Inspector/InspectorPanel.js 1`] = `
"type Props = $ReadOnly<{
devtoolsIsOpen: boolean,
inspecting: boolean,
setInspecting: (val: boolean) => void,
perfing: boolean,
setPerfing: (val: boolean) => void,
touchTargeting: boolean,
setTouchTargeting: (val: boolean) => void,
networking: boolean,
setNetworking: (val: boolean) => void,
hierarchy?: ?ElementsHierarchy,
selection?: ?number,
setSelection: (number) => mixed,
inspected?: ?InspectedElement,
}>;
declare class InspectorPanel extends React.Component<Props> {
renderWaiting(): React.Node;
render(): React.Node;
}
declare export default typeof InspectorPanel;
"
`;
exports[`public API should not change unintentionally Libraries/Inspector/NetworkOverlay.js 1`] = `
"type NetworkRequestInfo = {
id: number,
type?: string,
url?: string,
method?: string,
status?: number,
dataSent?: any,
responseContentType?: string,
responseSize?: number,
requestHeaders?: Object,
responseHeaders?: string,
response?: Object | string,
responseURL?: string,
responseType?: string,
timeout?: number,
closeReason?: string,
messages?: string,
serverClose?: Object,
serverError?: Object,
...
};
type Props = $ReadOnly<{}>;
type State = {
detailRowId: ?number,
requests: Array<NetworkRequestInfo>,
};
declare class NetworkOverlay extends React.Component<Props, State> {
_requestsListView: ?React.ElementRef<Class<FlatList<NetworkRequestInfo>>>;
_detailScrollView: ?React.ElementRef<typeof ScrollView>;
_requestsListViewScrollMetrics: {
contentLength: number,
offset: number,
visibleLength: number,
};
_socketIdMap: { [number]: number };
_xhrIdMap: { [key: number]: number, ... };
state: State;
_enableXHRInterception(): void;
_enableWebSocketInterception(): void;
componentDidMount(): void;
componentWillUnmount(): void;
_renderItem: $FlowFixMe;
_renderItemDetail(id: number): React.Node;
_indicateAdditionalRequests: $FlowFixMe;
_captureRequestsListView: $FlowFixMe;
_requestsListViewOnScroll: $FlowFixMe;
_pressRow(rowId: number): void;
_scrollDetailToTop: $FlowFixMe;
_closeButtonClicked: $FlowFixMe;
_getRequestIndexByXHRID(index: number): number;
render(): React.Node;
}
declare export default typeof NetworkOverlay;
"
`;
exports[`public API should not change unintentionally Libraries/Inspector/PerformanceOverlay.js 1`] = `
"declare class PerformanceOverlay extends React.Component<{ ... }> {
render(): React.Node;
}
declare export default typeof PerformanceOverlay;
"
`;
exports[`public API should not change unintentionally Libraries/Inspector/ReactDevToolsOverlay.js 1`] = `
"type Props = {
inspectedViewRef: InspectedViewRef,
reactDevToolsAgent: ReactDevToolsAgent,
};
declare export default function ReactDevToolsOverlay(Props): React.Node;
"
`;
exports[`public API should not change unintentionally Libraries/Inspector/StyleInspector.js 1`] = `
"type Props = $ReadOnly<{
style?: ?____FlattenStyleProp_Internal<ViewStyleProp>,
}>;
declare function StyleInspector(Props): React.Node;
declare export default typeof StyleInspector;
"
`;
exports[`public API should not change unintentionally Libraries/Inspector/getInspectorDataForViewAtPoint.js 1`] = `
"export type ReactRenderer = {
rendererConfig: {
getInspectorDataForViewAtPoint: (
inspectedView: ?HostInstance,
locationX: number,
locationY: number,
callback: Function
) => void,
...
},
};
declare function getInspectorDataForViewAtPoint(
inspectedView: ?HostInstance,
locationX: number,
locationY: number,
callback: (viewData: TouchedViewDataAtPoint) => boolean
): void;
declare export default typeof getInspectorDataForViewAtPoint;
"
`;
exports[`public API should not change unintentionally Libraries/Inspector/resolveBoxStyle.js 1`] = `
"declare function resolveBoxStyle(
prefix: string,
style: Object
): ?$ReadOnly<{
bottom: number,
left: number,
right: number,
top: number,
}>;
declare export default typeof resolveBoxStyle;
"
`;
exports[`public API should not change unintentionally Libraries/Interaction/FrameRateLogger.js 1`] = `
"declare const FrameRateLogger: {
setGlobalOptions: (options: { debug?: boolean, ... }) => void,
packages/react-native/Libraries/Inspector/BorderBox.js → packages/react-native/src/private/inspector/BorderBox.js
Vendored
+2 -2
View File
@@ -10,11 +10,11 @@
'use strict';
import type {ViewStyleProp} from '../StyleSheet/StyleSheet';
import type {ViewStyleProp} from '../../../Libraries/StyleSheet/StyleSheet';
import React from 'react';
const View = require('../Components/View/View').default;
const View = require('../../../Libraries/Components/View/View').default;
type Props = $ReadOnly<{
children: React.Node,
packages/react-native/Libraries/Inspector/BoxInspector.js → packages/react-native/src/private/inspector/BoxInspector.js
Vendored
+7 -4
View File
@@ -10,14 +10,17 @@
'use strict';
import type {TextStyleProp, ViewStyleProp} from '../StyleSheet/StyleSheet';
import type {
TextStyleProp,
ViewStyleProp,
} from '../../../Libraries/StyleSheet/StyleSheet';
import type {InspectedElementFrame} from './Inspector';
import React from 'react';
const View = require('../Components/View/View').default;
const StyleSheet = require('../StyleSheet/StyleSheet');
const Text = require('../Text/Text').default;
const View = require('../../../Libraries/Components/View/View').default;
const StyleSheet = require('../../../Libraries/StyleSheet/StyleSheet');
const Text = require('../../../Libraries/Text/Text').default;
const resolveBoxStyle = require('./resolveBoxStyle').default;
const blank = {
packages/react-native/Libraries/Inspector/ElementBox.js → packages/react-native/src/private/inspector/ElementBox.js
Vendored
+5 -5
View File
@@ -10,15 +10,15 @@
'use strict';
import type {ViewStyleProp} from '../StyleSheet/StyleSheet';
import type {ViewStyleProp} from '../../../Libraries/StyleSheet/StyleSheet';
import type {InspectedElementFrame} from './Inspector';
import React from 'react';
const View = require('../Components/View/View').default;
const flattenStyle = require('../StyleSheet/flattenStyle');
const StyleSheet = require('../StyleSheet/StyleSheet');
const Dimensions = require('../Utilities/Dimensions').default;
const View = require('../../../Libraries/Components/View/View').default;
const flattenStyle = require('../../../Libraries/StyleSheet/flattenStyle');
const StyleSheet = require('../../../Libraries/StyleSheet/StyleSheet');
const Dimensions = require('../../../Libraries/Utilities/Dimensions').default;
const BorderBox = require('./BorderBox').default;
const resolveBoxStyle = require('./resolveBoxStyle').default;
packages/react-native/Libraries/Inspector/ElementProperties.js → packages/react-native/src/private/inspector/ElementProperties.js
Vendored
+9 -9
View File
@@ -10,20 +10,20 @@
'use strict';
import type {InspectorData} from '../Renderer/shims/ReactNativeTypes';
import type {ViewStyleProp} from '../StyleSheet/StyleSheet';
import type {InspectorData} from '../../../Libraries/Renderer/shims/ReactNativeTypes';
import type {ViewStyleProp} from '../../../Libraries/StyleSheet/StyleSheet';
import React from 'react';
const TouchableHighlight =
require('../Components/Touchable/TouchableHighlight').default;
require('../../../Libraries/Components/Touchable/TouchableHighlight').default;
const TouchableWithoutFeedback =
require('../Components/Touchable/TouchableWithoutFeedback').default;
const View = require('../Components/View/View').default;
const flattenStyle = require('../StyleSheet/flattenStyle');
const StyleSheet = require('../StyleSheet/StyleSheet');
const Text = require('../Text/Text').default;
const mapWithSeparator = require('../Utilities/mapWithSeparator');
require('../../../Libraries/Components/Touchable/TouchableWithoutFeedback').default;
const View = require('../../../Libraries/Components/View/View').default;
const flattenStyle = require('../../../Libraries/StyleSheet/flattenStyle');
const StyleSheet = require('../../../Libraries/StyleSheet/StyleSheet');
const Text = require('../../../Libraries/Text/Text').default;
const mapWithSeparator = require('../../../Libraries/Utilities/mapWithSeparator');
const BoxInspector = require('./BoxInspector').default;
const StyleInspector = require('./StyleInspector').default;
packages/react-native/Libraries/Inspector/Inspector.js → packages/react-native/src/private/inspector/Inspector.js
Vendored
+13 -11
View File
@@ -10,23 +10,25 @@
'use strict';
import type {InspectedViewRef} from '../ReactNative/AppContainer-dev';
import type {InspectedViewRef} from '../../../Libraries/ReactNative/AppContainer-dev';
import type {
InspectorData,
TouchedViewDataAtPoint,
} from '../Renderer/shims/ReactNativeTypes';
import type {ViewStyleProp} from '../StyleSheet/StyleSheet';
import type {ReactDevToolsAgent} from '../Types/ReactDevToolsTypes';
} from '../../../Libraries/Renderer/shims/ReactNativeTypes';
import type {ViewStyleProp} from '../../../Libraries/StyleSheet/StyleSheet';
import type {ReactDevToolsAgent} from '../../../Libraries/Types/ReactDevToolsTypes';
import SafeAreaView from '../../src/private/components/SafeAreaView_INTERNAL_DO_NOT_USE';
import SafeAreaView from '../components/SafeAreaView_INTERNAL_DO_NOT_USE';
import React from 'react';
const View = require('../Components/View/View').default;
const PressabilityDebug = require('../Pressability/PressabilityDebug');
const {findNodeHandle} = require('../ReactNative/RendererProxy');
const StyleSheet = require('../StyleSheet/StyleSheet');
const Dimensions = require('../Utilities/Dimensions').default;
const Platform = require('../Utilities/Platform');
const View = require('../../../Libraries/Components/View/View').default;
const PressabilityDebug = require('../../../Libraries/Pressability/PressabilityDebug');
const {
findNodeHandle,
} = require('../../../Libraries/ReactNative/RendererProxy');
const StyleSheet = require('../../../Libraries/StyleSheet/StyleSheet');
const Dimensions = require('../../../Libraries/Utilities/Dimensions').default;
const Platform = require('../../../Libraries/Utilities/Platform');
const getInspectorDataForViewAtPoint =
require('./getInspectorDataForViewAtPoint').default;
const InspectorOverlay = require('./InspectorOverlay').default;
packages/react-native/Libraries/Inspector/InspectorOverlay.js → packages/react-native/src/private/inspector/InspectorOverlay.js
Vendored
+3 -3
View File
@@ -10,13 +10,13 @@
'use strict';
import type {PressEvent} from '../Types/CoreEventTypes';
import type {PressEvent} from '../../../Libraries/Types/CoreEventTypes';
import type {InspectedElement} from './Inspector';
import React from 'react';
const View = require('../Components/View/View').default;
const StyleSheet = require('../StyleSheet/StyleSheet');
const View = require('../../../Libraries/Components/View/View').default;
const StyleSheet = require('../../../Libraries/StyleSheet/StyleSheet');
const ElementBox = require('./ElementBox').default;
type Props = $ReadOnly<{
packages/react-native/Libraries/Inspector/InspectorPanel.js → packages/react-native/src/private/inspector/InspectorPanel.js
Vendored
+7 -6
View File
@@ -12,15 +12,16 @@
import type {ElementsHierarchy, InspectedElement} from './Inspector';
import SafeAreaView from '../Components/SafeAreaView/SafeAreaView';
import SafeAreaView from '../../../Libraries/Components/SafeAreaView/SafeAreaView';
import React from 'react';
const ScrollView = require('../Components/ScrollView/ScrollView').default;
const ScrollView =
require('../../../Libraries/Components/ScrollView/ScrollView').default;
const TouchableHighlight =
require('../Components/Touchable/TouchableHighlight').default;
const View = require('../Components/View/View').default;
const StyleSheet = require('../StyleSheet/StyleSheet');
const Text = require('../Text/Text').default;
require('../../../Libraries/Components/Touchable/TouchableHighlight').default;
const View = require('../../../Libraries/Components/View/View').default;
const StyleSheet = require('../../../Libraries/StyleSheet/StyleSheet');
const Text = require('../../../Libraries/Text/Text').default;
const ElementProperties = require('./ElementProperties').default;
const NetworkOverlay = require('./NetworkOverlay').default;
const PerformanceOverlay = require('./PerformanceOverlay').default;
packages/react-native/Libraries/Inspector/NetworkOverlay.js → packages/react-native/src/private/inspector/NetworkOverlay.js
Vendored
+8 -8
View File
@@ -12,18 +12,18 @@
import type {RenderItemProps} from '@react-native/virtualized-lists';
import ScrollView from '../Components/ScrollView/ScrollView';
import ScrollView from '../../../Libraries/Components/ScrollView/ScrollView';
import React from 'react';
const TouchableHighlight =
require('../Components/Touchable/TouchableHighlight').default;
const View = require('../Components/View/View').default;
const FlatList = require('../Lists/FlatList').default;
const XHRInterceptor = require('../Network/XHRInterceptor');
const StyleSheet = require('../StyleSheet/StyleSheet');
const Text = require('../Text/Text').default;
require('../../../Libraries/Components/Touchable/TouchableHighlight').default;
const View = require('../../../Libraries/Components/View/View').default;
const FlatList = require('../../../Libraries/Lists/FlatList').default;
const XHRInterceptor = require('../../../Libraries/Network/XHRInterceptor');
const StyleSheet = require('../../../Libraries/StyleSheet/StyleSheet');
const Text = require('../../../Libraries/Text/Text').default;
const WebSocketInterceptor =
require('../WebSocket/WebSocketInterceptor').default;
require('../../../Libraries/WebSocket/WebSocketInterceptor').default;
const LISTVIEW_CELL_HEIGHT = 15;
packages/react-native/Libraries/Inspector/PerformanceOverlay.js → packages/react-native/src/private/inspector/PerformanceOverlay.js
Vendored
+4 -4
View File
@@ -12,10 +12,10 @@
import React from 'react';
const View = require('../Components/View/View').default;
const StyleSheet = require('../StyleSheet/StyleSheet');
const Text = require('../Text/Text').default;
const PerformanceLogger = require('../Utilities/GlobalPerformanceLogger');
const View = require('../../../Libraries/Components/View/View').default;
const StyleSheet = require('../../../Libraries/StyleSheet/StyleSheet');
const Text = require('../../../Libraries/Text/Text').default;
const PerformanceLogger = require('../../../Libraries/Utilities/GlobalPerformanceLogger');
class PerformanceOverlay extends React.Component<{...}> {
render(): React.Node {
packages/react-native/Libraries/Inspector/ReactDevToolsOverlay.js → packages/react-native/src/private/inspector/ReactDevToolsOverlay.js
Vendored
+7 -7
View File
@@ -8,15 +8,15 @@
* @flow
*/
import type {InspectedViewRef} from '../ReactNative/AppContainer-dev';
import type {PointerEvent} from '../Types/CoreEventTypes';
import type {PressEvent} from '../Types/CoreEventTypes';
import type {ReactDevToolsAgent} from '../Types/ReactDevToolsTypes';
import type {InspectedViewRef} from '../../../Libraries/ReactNative/AppContainer-dev';
import type {PointerEvent} from '../../../Libraries/Types/CoreEventTypes';
import type {PressEvent} from '../../../Libraries/Types/CoreEventTypes';
import type {ReactDevToolsAgent} from '../../../Libraries/Types/ReactDevToolsTypes';
import type {InspectedElement} from './Inspector';
import View from '../Components/View/View';
import ReactNativeFeatureFlags from '../ReactNative/ReactNativeFeatureFlags';
import StyleSheet from '../StyleSheet/StyleSheet';
import View from '../../../Libraries/Components/View/View';
import ReactNativeFeatureFlags from '../../../Libraries/ReactNative/ReactNativeFeatureFlags';
import StyleSheet from '../../../Libraries/StyleSheet/StyleSheet';
import ElementBox from './ElementBox';
import * as React from 'react';
packages/react-native/Libraries/Inspector/StyleInspector.js → packages/react-native/src/private/inspector/StyleInspector.js
Vendored
+5 -5
View File
@@ -10,14 +10,14 @@
'use strict';
import type {ViewStyleProp} from '../StyleSheet/StyleSheet';
import type {____FlattenStyleProp_Internal} from '../StyleSheet/StyleSheetTypes';
import type {ViewStyleProp} from '../../../Libraries/StyleSheet/StyleSheet';
import type {____FlattenStyleProp_Internal} from '../../../Libraries/StyleSheet/StyleSheetTypes';
import React from 'react';
const View = require('../Components/View/View').default;
const StyleSheet = require('../StyleSheet/StyleSheet');
const Text = require('../Text/Text').default;
const View = require('../../../Libraries/Components/View/View').default;
const StyleSheet = require('../../../Libraries/StyleSheet/StyleSheet');
const Text = require('../../../Libraries/Text/Text').default;
type Props = $ReadOnly<{
style?: ?____FlattenStyleProp_Internal<ViewStyleProp>,
packages/react-native/Libraries/Inspector/getInspectorDataForViewAtPoint.js → packages/react-native/src/private/inspector/getInspectorDataForViewAtPoint.js
Vendored
+1 -1
View File
@@ -11,7 +11,7 @@
import type {
HostInstance,
TouchedViewDataAtPoint,
} from '../Renderer/shims/ReactNativeTypes';
} from '../../../Libraries/Renderer/shims/ReactNativeTypes';
const invariant = require('invariant');
packages/react-native/Libraries/Inspector/resolveBoxStyle.js → packages/react-native/src/private/inspector/resolveBoxStyle.js
Vendored
+2 -1
View File
@@ -10,7 +10,8 @@
'use strict';
const I18nManager = require('../ReactNative/I18nManager').default;
const I18nManager =
require('../../../Libraries/ReactNative/I18nManager').default;
/**
* Resolve a style property into its component parts.