Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix NullPointerException when reporting mounts for mount hooks (#39022)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39022

Fixes a possible NullPointerException thrown when trying to access the binding after the instance has been destroyed to report mounts.

I added a check for the mount item just in case 😅

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D48355738

fbshipit-source-id: 401d2e0a52b0764ed89498ecc0176d160226e509
This commit is contained in:
Rubén Norte
2023-08-16 04:38:47 -07:00
committed by Facebook GitHub Bot
parent 67f8d4014e
commit 0ba9808c88
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java
+4 -3
View File
@@ -1227,20 +1227,21 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
public void run() {
mMountNotificationScheduled.set(false);
if (mountItems == null) {
final @Nullable Binding binding = mBinding;
if (mountItems == null || binding == null) {
return;
}
// Collect surface IDs for all the mount items
List<Integer> surfaceIds = new ArrayList();
for (MountItem mountItem : mountItems) {
if (!surfaceIds.contains(mountItem.getSurfaceId())) {
if (mountItem != null && !surfaceIds.contains(mountItem.getSurfaceId())) {
surfaceIds.add(mountItem.getSurfaceId());
}
}
for (int surfaceId : surfaceIds) {
mBinding.reportMount(surfaceId);
binding.reportMount(surfaceId);
}
}
});