Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use ConcreteStateTeller in RCTLegacyViewManagerInteropComponentView

Browse Source 
Summary: Changelog: [Internal]

Reviewed By: JoshuaGross

Differential Revision: D23239097

fbshipit-source-id: 4c0d7b24917509d3d9660098349c226ad42e832e
This commit is contained in:
Samuel Susla
2020-08-24 06:39:29 -07:00
committed by Facebook GitHub Bot
parent 9a5807162c
commit 0b532e1be7
1 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/Fabric/Mounting/ComponentViews/LegacyViewManagerInterop/RCTLegacyViewManagerInteropComponentView.mm
+7 -9
View File
@@ -22,7 +22,7 @@ static NSString *const kRCTLegacyInteropChildIndexKey = @"index";
NSMutableArray<NSDictionary *> *_viewsToBeMounted;
NSMutableArray<UIView *> *_viewsToBeUnmounted;
RCTLegacyViewManagerInteropCoordinatorAdapter *_adapter;
LegacyViewManagerInteropShadowNode::ConcreteState::Shared _state;
LegacyViewManagerInteropShadowNode::ConcreteStateTeller _stateTeller;
}
- (instancetype)initWithFrame:(CGRect)frame
@@ -64,9 +64,9 @@ static NSString *const kRCTLegacyInteropChildIndexKey = @"index";
- (RCTLegacyViewManagerInteropCoordinator *)coordinator
{
if (_state != nullptr) {
const auto &state = _state->getData();
return unwrapManagedObject(state.coordinator);
auto data = _stateTeller.getData();
if (data.hasValue()) {
return unwrapManagedObject(data.value().coordinator);
} else {
return nil;
}
@@ -74,9 +74,7 @@ static NSString *const kRCTLegacyInteropChildIndexKey = @"index";
- (NSString *)componentViewName_DO_NOT_USE_THIS_IS_BROKEN
{
const auto &state = _state->getData();
RCTLegacyViewManagerInteropCoordinator *coordinator = unwrapManagedObject(state.coordinator);
return coordinator.componentViewName;
return self.coordinator.componentViewName;
}
#pragma mark - RCTComponentViewProtocol
@@ -86,7 +84,7 @@ static NSString *const kRCTLegacyInteropChildIndexKey = @"index";
_adapter = nil;
[_viewsToBeMounted removeAllObjects];
[_viewsToBeUnmounted removeAllObjects];
_state.reset();
_stateTeller.invalidate();
self.contentView = nil;
[super prepareForRecycle];
}
@@ -111,7 +109,7 @@ static NSString *const kRCTLegacyInteropChildIndexKey = @"index";
- (void)updateState:(State::Shared const &)state oldState:(State::Shared const &)oldState
{
_state = std::static_pointer_cast<LegacyViewManagerInteropShadowNode::ConcreteState const>(state);
_stateTeller.setConcreteState(state);
}
- (void)finalizeUpdates:(RNComponentViewUpdateMask)updateMask