Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixing line truncation issue when numberOfLines = {1} (#37667)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37667

Changelog:
[Android][Fixed] - Fixing line truncation issue in Text containing /n when numberOfLines = {1}

When the text has multiple lines (with new line characters \n to hard-break the lines), and the first line is short enough to fit, Text component with `numberOfLines = {1}` doesn't display "..." at the end and rather disrespects the /n character.

With `numberOfLines = {1}`, On iOS it translates to
`line 1`, on Android & Web it translates to `line 1 line 2...`

**Expected Behavior :**

`line 1...`

Reviewed By: javache, NickGerleman

Differential Revision: D46175963

fbshipit-source-id: 3377c38ab65e6801bddb1f262432f8d156a2641f
This commit is contained in:
Arushi Kesarwani
2023-06-05 23:31:10 -07:00
committed by Facebook GitHub Bot
parent cf27e246ce
commit 0af806e96c
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java
-1
View File
@@ -577,7 +577,6 @@ public class ReactTextView extends AppCompatTextView implements ReactCompoundVie
public void setNumberOfLines(int numberOfLines) {
mNumberOfLines = numberOfLines == 0 ? ViewDefaults.NUMBER_OF_LINES : numberOfLines;
setSingleLine(mNumberOfLines == 1);
setMaxLines(mNumberOfLines);
}