mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
fix: ignore build/ and DerivedData/ dirs in when reading infoPlistFiles (#51833)
Summary: https://github.com/facebook/react-native/pull/49927 introduced a regression where a Ruby script would read compilation artifacts and fail, when the user has relative build directories set in XCode. After successful compilation `build/` dir and `DerivedData/` dir have `.plist` files that aren't in UTF-8 encoding and shouldn't be read by the script. If the user tries to reinstall pods at this point, he gets the following error:  This is how you enable relative build directories in XCode.  ## Changelog: [IOS] [FIXED] - Ignore `build/` and `DerivedData/` directories when reading `.plist` files. Pull Request resolved: https://github.com/facebook/react-native/pull/51833 Test Plan: After applying this patch the problem doesn't occur anymore on my machine. Reviewed By: cortinico Differential Revision: D76030133 Pulled By: cipolleschi fbshipit-source-id: 7ae8c2d0ce28b6925245a9172154e3dcafee126f
This commit is contained in:
committed by
React Native Bot
parent
3d06f9e449
commit
0a9ea3932a
@@ -161,7 +161,7 @@ class NewArchitectureHelper
|
||||
.uniq{ |p| p.path }
|
||||
.map{ |p| p.path }
|
||||
|
||||
excluded_info_plist = ["/Pods", "Tests", "metainternal", ".bundle"]
|
||||
excluded_info_plist = ["/Pods", "Tests", "metainternal", ".bundle", "build/", "DerivedData/"]
|
||||
projectPaths.each do |projectPath|
|
||||
projectFolderPath = File.dirname(projectPath)
|
||||
infoPlistFiles = `find #{projectFolderPath} -name "Info.plist"`
|
||||
|
||||
Reference in New Issue
Block a user