Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update facebook::react::kNumberOfPropsPerComponentSoftCap

Browse Source 
Summary:
`butter::small_vector` is backed by a `folly:small_vector` on non-Android platforms in release mode.

It uses the small vector optimization, keeping a fixed size buffer, then falling back to heap allocation.

When I was debugging through props parsing code to figure out a prop not getting passed to Fabric (was being filtered in ViewConfig), I noticed this vector is filled with 199 elements for ViewProps. So It always overflows the current capacity and falls back to heap allocation. This bumps the capacity basde on what I observed with some more headroom.

Changelog:
[Internal]

Reviewed By: sammy-SC

Differential Revision: D47981105

fbshipit-source-id: 3870d8e4fee9748c487d01cc82284de865ea370d
This commit is contained in:
Nick Gerleman
2023-08-02 13:42:14 -07:00
committed by Facebook GitHub Bot
parent 8d8455c3c3
commit 0a1c2efcc1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactCommon/react/renderer/core/RawPropsPrimitives.h
+1 -1
View File
@@ -40,7 +40,7 @@ constexpr static RawPropsValueIndex kRawPropsValueIndexEmpty =
* about twenty. It's okay if some `*Props` class has more than this amount of
* props but the majority of those classes should be below this cap.
*/
constexpr static auto kNumberOfPropsPerComponentSoftCap = 150;
constexpr static auto kNumberOfPropsPerComponentSoftCap = 250;
/*
* The maximum length of the prop name.