Do not log image if it fails lifecycle assert in getWillRequestUrlTime

Reviewed By: sammy-SC

Differential Revision: D24990452

fbshipit-source-id: ce4d5ec9e3cf237c6edbd17368f2dcf3aecbec2b

ReactCommon/react/renderer/imagemanager/ImageTelemetry.cpp

@@ -10,17 +10,11 @@
 namespace facebook {
 namespace react {
 
-void ImageTelemetry::willRequestUrl() {
-  assert(willRequestUrlTime_ == kTelemetryUndefinedTimePoint);
-  willRequestUrlTime_ = telemetryTimePointNow();
-}
-
 SurfaceId ImageTelemetry::getSurfaceId() const {
   return surfaceId_;
 }
 
 TelemetryTimePoint ImageTelemetry::getWillRequestUrlTime() const {
-  assert(willRequestUrlTime_ != kTelemetryUndefinedTimePoint);
   return willRequestUrlTime_;
 }
 

ReactCommon/react/renderer/imagemanager/ImageTelemetry.h

@@ -15,25 +15,20 @@ namespace react {
 
 /*
  * Represents telemetry data associated with a image request
+ * where the willRequestUrlTime is the time at ImageTelemetry's creation.
  */
 class ImageTelemetry final {
  public:
-  ImageTelemetry(SurfaceId const surfaceId) : surfaceId_(surfaceId) {}
+  ImageTelemetry(SurfaceId const surfaceId) : surfaceId_(surfaceId) {
+    willRequestUrlTime_ = telemetryTimePointNow();
+  }
 
-  /*
-   * Signaling
-   */
-  void willRequestUrl();
-
-  /*
-   * Reading
-   */
   TelemetryTimePoint getWillRequestUrlTime() const;
 
   SurfaceId getSurfaceId() const;
 
  private:
-  TelemetryTimePoint willRequestUrlTime_{kTelemetryUndefinedTimePoint};
+  TelemetryTimePoint willRequestUrlTime_;
 
   const SurfaceId surfaceId_;
 };

ReactCommon/react/renderer/imagemanager/platform/ios/RCTImageManager.mm

@@ -44,7 +44,6 @@ using namespace facebook::react;
   std::shared_ptr<ImageTelemetry> telemetry;
   if ([self->_imageLoader shouldEnablePerfLoggingForRequestUrl:request.URL]) {
     telemetry = std::make_shared<ImageTelemetry>(surfaceId);
-    telemetry->willRequestUrl();
   } else {
     telemetry = nullptr;
   }